From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Kurt Van Dijck <kurt.van.dijck@eia.be>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org
Subject: Re: [PATCH v4 2/5] can: add rtnetlink support
Date: Sun, 01 May 2011 19:16:54 +0200 [thread overview]
Message-ID: <4DBD9586.7080908@hartkopp.net> (raw)
In-Reply-To: <20110427085705.GC757@kurt.e-circ.dyndns.org>
On 27.04.2011 10:57, Kurt Van Dijck wrote:
> This patch adds rtnetlink support for AF_CAN. This support is really
> a multiplexer towards the different CAN protocols.
Hello Kurt,
i applied all your patches for the can-utils and the network layer stuff to
the BerliOS SVN in socketcan/branches/j1939 for testing.
Besides some minor adaptions to support the SVN i left out some infrastructure
changes you made in patch 2/5 to constify this ...
> -static struct can_proto *proto_tab[CAN_NPROTO] __read_mostly;
> +static const struct can_proto *proto_tab[CAN_NPROTO] __read_mostly;
and this ...
> -static struct can_proto *can_try_module_get(int protocol)
> +static const struct can_proto *can_try_module_get(int protocol)
(..)
> +static inline void can_put_proto(const struct can_proto *cp)
> +{
> + module_put(cp->prot->owner);
> +}
These infrastructure changes did not really belong to the rtnetlink support.
The can-j1939.ko builds properly in the SVN against 2.6.39-rc5 and the
net-next-2.6 tree - and e.g. against a debian wheezy kernel:
make KERNELDIR=/usr/src/linux-headers-2.6.38-2-686-bigmem
As it is pretty easy now to build the kernel modules & your provided can-utils
we hopefully get some more feedback from j1939 users.
Best regards,
Oliver
next prev parent reply other threads:[~2011-05-01 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 8:53 [PATCH v4 0/5] CAN: add SAE J1939 protocol Kurt Van Dijck
[not found] ` <20110427085330.GA757-ozGf4kBk5synFtIcQ8t7k3L8HoS0Hn3T@public.gmane.org>
2011-04-27 8:55 ` [PATCH v4 1/5] can: extend sockaddr_can to include j1939 members Kurt Van Dijck
2011-04-27 8:57 ` [PATCH v4 2/5] can: add rtnetlink support Kurt Van Dijck
2011-05-01 17:16 ` Oliver Hartkopp [this message]
[not found] ` <4DBD9586.7080908-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-05-02 7:36 ` Kurt Van Dijck
2011-05-04 4:20 ` Kurt Van Dijck
2011-04-27 8:58 ` [PATCH v4 3/5] can-j1939: Import SAE J1939 stack Kurt Van Dijck
2011-04-27 9:00 ` [PATCH v4 4/5] can-j1939: add documentation Kurt Van Dijck
2011-04-27 9:03 ` [PATCH v4 5/5] iproute2: add can-j1939 support Kurt Van Dijck
[not found] ` <20110427090302.GF757-ozGf4kBk5synFtIcQ8t7k3L8HoS0Hn3T@public.gmane.org>
2011-05-02 13:21 ` Marc Kleine-Budde
[not found] ` <4DBEAFC6.7010308-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-05-02 13:36 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBD9586.7080908@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).