netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Franco Fichtner <franco@lastsummer.de>
To: Netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings
Date: Thu, 12 May 2011 10:05:58 +0200	[thread overview]
Message-ID: <4DCB94E6.2020407@lastsummer.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Hi all,

I found this while skimming through recent net-next patches.
I'm not quite sure if the padding in this struct is correct now.


Franco

[-- Attachment #2: 0001-ethtool-bring-back-missing-comma-in-netdev_features_.patch --]
[-- Type: text/x-patch, Size: 990 bytes --]

>From c62ca7bb87baad78e285dc0e698e792051d8fa87 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@lastsummer.de>
Date: Wed, 11 May 2011 09:49:08 +0200
Subject: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings

The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <franco@lastsummer.de>
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
 	/* NETIF_F_NTUPLE */          "rx-ntuple-filter",
 	/* NETIF_F_RXHASH */          "rx-hashing",
 	/* NETIF_F_RXCSUM */          "rx-checksum",
-	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
 	/* NETIF_F_LOOPBACK */        "loopback",
 };
 
-- 
1.7.3.2.493.g0b0cd


             reply	other threads:[~2011-05-12  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12  8:05 Franco Fichtner [this message]
2011-05-12  8:55 ` [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings Michał Mirosław
2011-05-12  9:13   ` Franco Fichtner
2011-05-12 11:33     ` Michał Mirosław

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCB94E6.2020407@lastsummer.de \
    --to=franco@lastsummer.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).