From: Franco Fichtner <franco@lastsummer.de>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: Franco Fichtner <franco@lastsummer.de>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings
Date: Thu, 12 May 2011 11:13:41 +0200 [thread overview]
Message-ID: <4DCBA4C5.5040308@lastsummer.de> (raw)
In-Reply-To: <BANLkTikH2uY_crot1DRBFZv9ifmvPQeRog@mail.gmail.com>
On 12/05/11 10:55, Michał Mirosław wrote:
> 2011/5/12 Franco Fichtner <franco@lastsummer.de>:
>> I found this while skimming through recent net-next patches.
>> I'm not quite sure if the padding in this struct is correct now.
> Nice catch. But please send the patch inline instead of as an attachment.
Thanks, but I have a short question. Are the empty strings in
this struct really needed?
/* NETIF_F_TSO6 */ "tx-tcp6-segmentation",
/* NETIF_F_FSO */ "tx-fcoe-segmentation",
"",
"",
/* NETIF_F_FCOE_CRC */ "tx-checksum-fcoe-crc",
They seem to have caused this mess in the first place and I would
think they could be removed entirely.
I will resend the patch later today as inline. Sorry about that.
Franco
next prev parent reply other threads:[~2011-05-12 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 8:05 [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings Franco Fichtner
2011-05-12 8:55 ` Michał Mirosław
2011-05-12 9:13 ` Franco Fichtner [this message]
2011-05-12 11:33 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBA4C5.5040308@lastsummer.de \
--to=franco@lastsummer.de \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).