netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org,
	davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
	Subhasish Ghosh
	<subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	nsekhar-l0cyMroinI0@public.gmane.org,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	CAN NETWORK DRIVERS
	<socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org>,
	Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>,
	Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	m-watkins-l0cyMroinI0@public.gmane.org,
	Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver.
Date: Thu, 12 May 2011 15:04:50 +0200	[thread overview]
Message-ID: <4DCBDAF2.7040101@pengutronix.de> (raw)
In-Reply-To: <201105121454.47781.arnd-r2nGTMty4D4@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]

On 05/12/2011 02:54 PM, Arnd Bergmann wrote:
> On Thursday 12 May 2011, Wolfgang Grandegger wrote:
>> Well, that seems sophisticated resulting in a complex implementation
>> (may code line) also because hardware filters are very hardware
>> dependent. Usually just one global filter can be defined. I think that's
>> overkill. A simple interface using:
>>
>>   ip link set can0 type can filter <id>:<mask> [<id>:<mask> ...]
>>
>> would just be fine.
> 
> Ok, fair enough. Still I would suggest you first come up with
> a reasonable user interface (the one you posted may be just right,
> I don't know), and then let someone do the implementation in the
> pruss firmware that is the best match for the user interface, rather
> than the other way around.

I suggested some time ago to implement the more-or-less standard
<id>:<mask> filter instead of just a single <id> (per filter entry). The
cost is probably quite low, it's just a single AND operation per filter
entry more expensive.

regards, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 188 bytes --]

_______________________________________________
Socketcan-core mailing list
Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
https://lists.berlios.de/mailman/listinfo/socketcan-core

  parent reply	other threads:[~2011-05-12 13:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com>
2011-04-22 12:11 ` [PATCH v4 1/1] can: add pruss CAN driver Subhasish Ghosh
     [not found]   ` <1303474267-6344-2-git-send-email-subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2011-04-22 15:50     ` Marc Kleine-Budde
     [not found]       ` <4DB1A3B7.7060300-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-04-25 20:06         ` Wolfgang Grandegger
     [not found]           ` <4DB5D452.9050500-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-04-27 13:08             ` Subhasish Ghosh
2011-04-27 13:21               ` Marc Kleine-Budde
2011-04-27 13:25               ` Arnd Bergmann
     [not found]                 ` <201104271525.28512.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-04  7:13                   ` Subhasish Ghosh
2011-05-04 13:11                     ` Arnd Bergmann
     [not found]                       ` <201105041511.54095.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-04 14:33                         ` Wolfgang Grandegger
     [not found]                           ` <4DC163D7.9010309-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-05-04 14:48                             ` Arnd Bergmann
     [not found]                               ` <201105041648.37199.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-04 16:00                                 ` Wolfgang Grandegger
     [not found]                                   ` <4DC17831.3070801-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-05-10 10:11                                     ` Subhasish Ghosh
2011-05-10 10:27                                       ` Alan Cox
     [not found]                                         ` <20110510112734.54160824-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2011-05-10 12:21                                           ` Subhasish Ghosh
2011-05-11 21:31                                             ` Arnd Bergmann
     [not found]                                               ` <201105112331.47954.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-11 21:44                                                 ` Arnd Bergmann
     [not found]                                                   ` <201105112344.44171.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-11 22:39                                                     ` Marc Kleine-Budde
2011-05-11 22:56                                                       ` Alan Cox
     [not found]                                                         ` <20110511235652.7ccddb3b-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2011-05-12  3:03                                                           ` can: hardware vs. software filter Kurt Van Dijck
2011-05-12  7:13                                                     ` [PATCH v4 1/1] can: add pruss CAN driver Wolfgang Grandegger
     [not found]                                                       ` <4DCB88A4.2010901-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-05-12 10:58                                                         ` Kurt Van Dijck
2011-05-12 12:54                                                         ` Arnd Bergmann
     [not found]                                                           ` <201105121454.47781.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-12 13:04                                                             ` Marc Kleine-Budde [this message]
2011-05-12 14:41                                                         ` Oliver Hartkopp
     [not found]                                                           ` <4DCBF1B6.6000104-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-05-22 10:30                                                             ` Arnd Bergmann
     [not found]                                                               ` <201105221230.56243.arnd-r2nGTMty4D4@public.gmane.org>
2011-05-23  6:21                                                                 ` Oliver Hartkopp
     [not found]                                                                   ` <4DD9FCFC.10803-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-05-23  8:23                                                                     ` Marc Kleine-Budde
2011-05-27  8:31                                                                     ` Wolfgang Grandegger
2011-05-12  7:04                                                 ` Wolfgang Grandegger
2011-05-04 15:57                             ` Kurt Van Dijck
2011-05-04 16:09                               ` Wolfgang Grandegger
     [not found]                               ` <4DC17A31.8070409@grandegger.com>
     [not found]                                 ` <4DC17A31.8070409-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-05-04 20:55                                   ` Oliver Hartkopp
2011-04-27 13:28               ` Wolfgang Grandegger
     [not found]                 ` <4DB81A12.1000006-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-04-27 13:34                   ` Wolfgang Grandegger
2011-04-24 11:13   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCBDAF2.7040101@pengutronix.de \
    --to=mkl-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m-watkins-l0cyMroinI0@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).