From: David Decotigny <decot@google.com>
To: netdev@vger.kernel.org
Cc: Florian Weimer <fweimer@bfk.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"David S. Miller" <davem@davemloft.net>,
Joe Perches <joe@perches.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
linux-kernel@vger.kernel.org
Subject: dl2k/stmmac patches (was Re: [PATCH 2/2] net/dl2k: Don't reconfigure link @100Mbps when disabling autoneg @1Gbps)
Date: Fri, 13 May 2011 08:54:18 -0700 [thread overview]
Message-ID: <4DCD542A.4010904@google.com> (raw)
In-Reply-To: <82y62dk1qz.fsf@mid.bfk.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
An update on the patch series I posted earlier (dl2k/stmmac autoneg
minor changes: see my posts on 05/09/11 17:19 PST)...
I'd suggest dropping the patch concerning dl2k, as I don't have any way
to claim it's any good at all (though I'm pretty confident it doesn't
make things any worse).
However, for the other patch of the same series (stmmac), please
consider for inclusion the new version prepared by Giuseppe instead of
my initial patch, for his version readily integrates my patch and has
been tested on real hardware:
stmmac: don't go through ethtool to start auto-negotiation
stmmac: fix autoneg in set_pauseparam
Regards,
Thank you!
On 05/11/11 02:47, Florian Weimer wrote:
> * David Decotigny:
>
>> Tested: module compiling, NOT tested on real hardware.
>
> To my knowledge, dl2k is broken. Some sort of synchronization
> primitives are missing. Under load, the NIC's notion of ring buffer
> status diverges from the host's view. 8-(
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk3NVCYACgkQld7vhusVrCHUEACggeKyCmoEHy9AzYec/aW8cDjU
GyAAoIiESxUAFWuKBmCOA31X/V0fvC+Y
=6hXY
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-05-13 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 0:19 [PATCH 0/2] Minor autonegociation changes, testers welcome David Decotigny
2011-05-10 0:19 ` [PATCH 1/2] net/stmmac: don't go through ethtool to start autonegociation David Decotigny
2011-05-10 13:47 ` Giuseppe CAVALLARO
2011-05-13 6:31 ` Giuseppe CAVALLARO
2011-05-10 0:19 ` [PATCH 2/2] net/dl2k: Don't reconfigure link @100Mbps when disabling autoneg @1Gbps David Decotigny
2011-05-10 18:55 ` Ben Hutchings
2011-05-10 22:14 ` David Decotigny
2011-05-11 9:47 ` Florian Weimer
2011-05-13 15:54 ` David Decotigny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCD542A.4010904@google.com \
--to=decot@google.com \
--cc=davem@davemloft.net \
--cc=david@decotigny.fr \
--cc=fweimer@bfk.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).