From: "Justin P. Mattock" <justinmattock@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, greearb@candelatech.com
Subject: Re: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.
Date: Mon, 23 May 2011 23:45:35 -0700 [thread overview]
Message-ID: <4DDB540F.6060603@gmail.com> (raw)
In-Reply-To: <20110524.022144.2121988243667976554.davem@davemloft.net>
On 05/23/2011 11:21 PM, David Miller wrote:
> From: "Justin P. Mattock"<justinmattock@gmail.com>
> Date: Mon, 23 May 2011 22:40:47 -0700
>
>> The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
>> so that it prints out just the fullname of vlan and the version number.
>
> Come on Justin, you're making various strings now completely
> unreferenced. Don't just leave them there, remove them.
>
ah.. I did think, but was warry about removing them. resent with the
references removed(hopefully).
Justin P. Mattock
prev parent reply other threads:[~2011-05-24 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 5:40 [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version Justin P. Mattock
2011-05-24 5:45 ` Eric Dumazet
2011-05-24 5:54 ` Joe Perches
2011-05-24 6:21 ` David Miller
2011-05-24 6:45 ` Justin P. Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB540F.6060603@gmail.com \
--to=justinmattock@gmail.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).