From: Ben Greear <greearb@candelatech.com>
To: chetan loke <loke.chetan@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 01/01]af_packet: Enhance network capture visibility
Date: Wed, 25 May 2011 16:10:22 -0700 [thread overview]
Message-ID: <4DDD8C5E.7040207@candelatech.com> (raw)
In-Reply-To: <BANLkTimYVUkUWA2XPix2nUL-=rnQKghZQA@mail.gmail.com>
On 05/25/2011 04:03 PM, chetan loke wrote:
> This patch is not complete and is intended to:
> a) demonstrate the improvments
> b) gather suggestions
>
>
> Signed-off-by: Chetan Loke<lokec@ccs.neu.edu>
> +struct tpacket3_hdr {
> + __u32 tp_status;
> + __u32 tp_len;
> + __u32 tp_snaplen;
> + __u16 tp_mac;
> + __u16 tp_net;
> + __u32 tp_sec;
> + __u32 tp_nsec;
> + __u16 tp_vlan_tci;
> + long tp_next_offset;
> +};
Use fixed-size variables, like __u64 instead of 'long'. That way,
you have the same sized msgs on 32 and 64-bit systems.
I didn't look at the rest of it in any detail, so no comment there.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-05-25 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 23:03 [RFC 01/01]af_packet: Enhance network capture visibility chetan loke
2011-05-25 23:10 ` Ben Greear [this message]
2011-05-25 23:24 ` chetan loke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD8C5E.7040207@candelatech.com \
--to=greearb@candelatech.com \
--cc=loke.chetan@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).