From: Arun Sharma <asharma@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Maximilian Engelhardt <maxi@daemonizer.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
StuStaNet Vorstand <vorstand@stusta.mhn.de>
Subject: Re: Kernel crash after using new Intel NIC (igb)
Date: Thu, 26 May 2011 17:09:41 -0700 [thread overview]
Message-ID: <4DDEEBC5.80804@fb.com> (raw)
In-Reply-To: <1306447292.2543.32.camel@edumazet-laptop>
On 5/26/11 3:01 PM, Eric Dumazet wrote:
>> Yeah - using the refcnt seems better than list_empty(), but I'm not sure
>> that your patch addresses the race above.
>
> It does.
True. I can't find any holes in this method and it resolves the "failure
to unlink from unused" case.
Perhaps wrap the while(1) loop into its own primitive in atomic.h or use
an existing primitive?
-Arun
next prev parent reply other threads:[~2011-05-27 0:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 22:32 Kernel crash after using new Intel NIC (igb) Maximilian Engelhardt
2011-04-26 23:34 ` Wyborny, Carolyn
2011-04-27 11:46 ` Maximilian Engelhardt
2011-04-27 12:04 ` Eric Dumazet
2011-04-27 4:24 ` Eric Dumazet
2011-04-27 4:32 ` Eric Dumazet
2011-04-27 11:51 ` Maximilian Engelhardt
2011-05-12 21:10 ` Arun Sharma
2011-05-12 21:15 ` Eric Dumazet
2011-05-24 21:33 ` Arun Sharma
2011-05-25 2:44 ` Eric Dumazet
2011-05-25 6:06 ` Arun Sharma
2011-05-25 6:35 ` Eric Dumazet
2011-05-26 15:06 ` Ben Hutchings
2011-05-26 19:30 ` Arun Sharma
2011-05-26 19:47 ` Eric Dumazet
2011-05-26 21:48 ` Arun Sharma
2011-05-26 22:01 ` Eric Dumazet
2011-05-27 0:09 ` Arun Sharma [this message]
2011-05-27 3:27 ` Eric Dumazet
2011-05-27 7:56 ` Yann Dupont
2011-05-27 17:40 ` David Miller
2011-05-27 17:52 ` Arun Sharma
2011-05-27 19:56 ` Eric Dumazet
2011-05-27 21:14 ` Arun Sharma
2011-05-28 5:41 ` Eric Dumazet
2011-05-28 18:04 ` Ingo Molnar
2011-05-29 7:33 ` Eric Dumazet
2011-05-29 7:38 ` Ingo Molnar
2011-05-29 7:43 ` Eric Dumazet
2011-05-29 12:33 ` Ingo Molnar
2011-05-30 18:34 ` Arun Sharma
2011-05-31 10:50 ` Ingo Molnar
2011-07-13 13:38 ` Maximilian Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDEEBC5.80804@fb.com \
--to=asharma@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=netdev@vger.kernel.org \
--cc=vorstand@stusta.mhn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).