From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>, Flavio Leitner <fbl@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net, andy@greyhouse.net
Subject: Re: [patch net-next-2.6 v2] bonding: allow resetting slave failure counters
Date: Wed, 01 Jun 2011 21:23:11 +0200 [thread overview]
Message-ID: <4DE6919F.3030304@gmail.com> (raw)
In-Reply-To: <20110601163153.GB2784@psychotron.redhat.com>
Le 01/06/2011 18:31, Jiri Pirko a écrit :
> This patch allows to reset failure counters for all enslaved devices.
Hi Jiri,
Why do we need a way to reset those counters? What is the problem with having those counters
monotonically increase until the system is rebooted? Do we have a way to reset other network
statistics (/sys/class/net/eth0/statistics/* for example)?
Except from this "do we need this feature" question, the code sounds good to me.
Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Nicolas.
next prev parent reply other threads:[~2011-06-01 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 9:40 [patch net-next-2.6] bonding: allow resetting slave failure counters Jiri Pirko
2011-06-01 13:28 ` Flavio Leitner
2011-06-01 13:53 ` Jiri Pirko
2011-06-01 16:13 ` Jay Vosburgh
2011-06-01 16:31 ` [patch net-next-2.6 v2] " Jiri Pirko
2011-06-01 16:41 ` Flavio Leitner
2011-06-01 19:23 ` Nicolas de Pesloüan [this message]
2011-06-01 20:08 ` Jiri Pirko
2011-06-01 20:12 ` David Miller
2011-06-01 20:27 ` Jiri Pirko
2011-06-01 19:03 ` [patch net-next-2.6] " David Miller
2011-06-01 19:11 ` Flavio Leitner
2011-06-01 19:22 ` David Miller
2011-06-01 19:53 ` Jay Vosburgh
2011-06-01 20:22 ` Flavio Leitner
2011-06-01 19:34 ` Nicolas de Pesloüan
2011-06-01 20:07 ` Jiri Pirko
2011-06-01 13:51 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE6919F.3030304@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).