From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Subject: Re: bridge/netfilter: regression in 2.6.39.1 Date: Mon, 06 Jun 2011 13:48:51 +0200 Message-ID: <4DECBEA3.6070408@ahsoftware.de> References: <4DE93422.3070000@ahsoftware.de> <20110606111507.GA1000@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Eric Dumazet , David Miller , Herbert Xu , netdev@vger.kernel.org To: Neil Horman Return-path: Received: from h1446028.stratoserver.net ([85.214.92.142]:60964 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998Ab1FFLtK (ORCPT ); Mon, 6 Jun 2011 07:49:10 -0400 In-Reply-To: <20110606111507.GA1000@hmsreliant.think-freely.org> Sender: netdev-owner@vger.kernel.org List-ID: Am 06.06.2011 13:15, schrieb Neil Horman: > On Fri, Jun 03, 2011 at 09:21:06PM +0200, Alexander Holler wrote: >> Hello, >> >> I'm getting a oops in the bridge code in br_change_mtu() with >> 2.6.39.1. The patch below seems to fix that. >> >> I'm not sure about the usage of dst_cow_metrics_generic() in >> fake_dst_ops, but after having a quick look at it seems to be ok to >> use that here. >> >> Regards, >> >> Alexander >> > How did the flags of the dst entry on which we're callnig dst_entry_write_ptr > wind up getting the READ_ONLY flag set on it? I don't see how we'er falling > into that clause in which we call cow_metrics when we call dst_metric_set. It > seems like that flag is set erroneously. perhaps we should just update > fake_rtable.dst to have the correct flags? > Neil It is set by that change: -------- @@ -124,7 +128,7 @@ void br_netfilter_rtable_init(struct net_bridge *br) atomic_set(&rt->dst.__refcnt, 1); rt->dst.dev = br->dev; rt->dst.path = &rt->dst; - dst_metric_set(&rt->dst, RTAX_MTU, 1500); + dst_init_metrics(&rt->dst, br_dst_default_metrics, true); rt->dst.flags = DST_NOXFRM; rt->dst.ops = &fake_dst_ops; } -------- The true in dst_init_metrics() is responsible for that flag. Regards, Alexander