netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Brad Campbell <brad@fnarfbargle.com>,
	Bart De Schuymer <bdschuym@pandora.be>,
	kvm@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: KVM induced panic on 2.6.38[2367] & 2.6.39
Date: Wed, 08 Jun 2011 00:57:07 +0200	[thread overview]
Message-ID: <4DEEACC3.3030509@trash.net> (raw)
In-Reply-To: <1307471484.3091.43.camel@edumazet-laptop>

On 07.06.2011 20:31, Eric Dumazet wrote:
> Le mardi 07 juin 2011 à 17:35 +0200, Patrick McHardy a écrit :
> 
>> The main suspects would be NAT and TCPMSS. Did you also try whether
>> the crash occurs with only one of these these rules?
>>
>>> I've just compiled out CONFIG_BRIDGE_NETFILTER and can no longer access
>>> the address the way I was doing it, so that's a no-go for me.
>>
>> That's really weird since you're apparently not using any bridge
>> netfilter features. It shouldn't have any effect besides changing
>> at which point ip_tables is invoked. How are your network devices
>> configured (specifically any bridges)?
> 
> Something in the kernel does 
> 
> u16 *ptr = addr (given by kmalloc())
> 
> ptr[-1] = 0;
> 
> Could be an off-one error in a memmove()/memcopy() or loop...
> 
> I cant see a network issue here.

So far me neither, but netfilter appears to trigger the bug.

> I checked arch/x86/lib/memmove_64.S and it seems fine.

I was thinking it might be a missing skb_make_writable() combined
with vhost_net specifics in the netfilter code (TCPMSS and NAT are
both suspect), but was unable to find something. I also went
through the dst_metrics() conversion to see whether anything could
cause problems with the bridge fake_rttable, but also nothing
so far.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-07 22:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DE44333.9000903@fnarfbargle.com>
     [not found] ` <20110531054729.GA16852@liondog.tnic>
     [not found]   ` <4DE4B432.1090203@fnarfbargle.com>
     [not found]     ` <20110531103808.GA6915@eferding.osrc.amd.com>
     [not found]       ` <4DE4FA2B.2050504@fnarfbargle.com>
     [not found]         ` <alpine.LSU.2.00.1105311517480.21107@sister.anvils>
     [not found]           ` <4DE589C5.8030600@fnarfbargle.com>
     [not found]             ` <20110601011527.GN19505@random.random>
     [not found]               ` <alpine.LSU.2.00.1105312120530.22808@sister.anvils>
     [not found]                 ` <4DE5DCA8.7070704@fnarfbargle.com>
     [not found]                   ` <4DE5E29E.7080009@redhat.com>
     [not found]                     ` <4DE60669.9050606@fnarfbargle.com>
     [not found]                       ` <4DE60918.3010008@redhat.com>
     [not found]                         ` <4DE60940.1070107@redhat.com>
     [not found]                           ` <4DE61A2B.7000008@fnarfbargle.com>
2011-06-01 11:09                             ` KVM induced panic on 2.6.38[2367] & 2.6.39 Avi Kivity
2011-06-01 11:18                             ` CaT
2011-06-01 11:52                               ` Brad Campbell
2011-06-01 23:03                                 ` CaT
2011-06-03 13:38                                   ` Brad Campbell
2011-06-03 15:50                                     ` Bernhard Held
2011-06-03 16:07                                       ` Brad Campbell
2011-06-06 20:10                                         ` Bart De Schuymer
2011-06-06 20:23                                           ` Eric Dumazet
2011-06-07  3:33                                           ` Brad Campbell
2011-06-07 13:30                                             ` Patrick McHardy
2011-06-07 14:40                                               ` Brad Campbell
2011-06-07 15:35                                                 ` Patrick McHardy
2011-06-07 18:31                                                   ` Eric Dumazet
2011-06-07 22:57                                                     ` Patrick McHardy [this message]
2011-06-08  0:18                                                       ` Brad Campbell
2011-06-08  3:59                                                         ` Eric Dumazet
2011-06-08 17:02                                                           ` Brad Campbell
2011-06-08 21:22                                                             ` Eric Dumazet
2011-06-10  2:52                                                             ` Simon Horman
2011-06-10 12:37                                                               ` Mark Lord
2011-06-10 16:43                                                                 ` Henrique de Moraes Holschuh
2011-06-12 15:38                                                               ` Avi Kivity
2011-06-07 23:43                                                   ` Brad Campbell
2011-06-07 18:04                                                 ` Bart De Schuymer
2011-06-08  0:15                                                   ` Brad Campbell
2011-06-05  8:14                                     ` Avi Kivity
2011-06-05 13:45                                       ` Brad Campbell
2011-06-05 13:58                                         ` Avi Kivity
2011-06-06 20:22                                         ` Eric Dumazet
2011-06-07 13:27                                           ` Brad Campbell
2011-06-07 13:37                                             ` Eric Dumazet
2011-06-07 15:15                                               ` Brad Campbell
2011-08-20 13:16                                               ` Brad Campbell
2011-08-22  6:36                                                 ` Avi Kivity
2011-08-22  6:45                                                   ` Eric Dumazet
2011-08-22 11:45                                                     ` Brad Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEEACC3.3030509@trash.net \
    --to=kaber@trash.net \
    --cc=bdschuym@pandora.be \
    --cc=brad@fnarfbargle.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).