* [PATCH] sctp: kzalloc() error handling on deleting last address
@ 2011-06-10 8:07 Michio Honda
2011-06-10 8:21 ` Wei Yongjun
0 siblings, 1 reply; 2+ messages in thread
From: Michio Honda @ 2011-06-10 8:07 UTC (permalink / raw)
To: David Miller; +Cc: Wei Yongjun, netdev
>From 49a66ecad72af8c367b125c695a113d3f3870320 Mon Sep 17 00:00:00 2001
From: Michio Honda <micchie@sfc.wide.ad.jp>
Date: Fri, 10 Jun 2011 16:42:14 +0900
Subject: [PATCH] sctp: kzalloc() error handling on deleting last address
Signed-off-by: Michio Honda <micchie@sfc.wide.ad.jp>
---
net/sctp/socket.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index e7e1b14..a23d898 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -786,6 +786,8 @@ static int sctp_send_asconf_del_ip(struct sock *sk,
continue;
asoc->asconf_addr_del_pending =
kzalloc(sizeof(union sctp_addr), GFP_ATOMIC);
+ if (asoc->asconf_addr_del_pending == NULL)
+ continue;
asoc->asconf_addr_del_pending->sa.sa_family =
addrs->sa_family;
asoc->asconf_addr_del_pending->v4.sin_port =
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sctp: kzalloc() error handling on deleting last address
2011-06-10 8:07 [PATCH] sctp: kzalloc() error handling on deleting last address Michio Honda
@ 2011-06-10 8:21 ` Wei Yongjun
0 siblings, 0 replies; 2+ messages in thread
From: Wei Yongjun @ 2011-06-10 8:21 UTC (permalink / raw)
To: Michio Honda; +Cc: David Miller, netdev
> From 49a66ecad72af8c367b125c695a113d3f3870320 Mon Sep 17 00:00:00 2001
> From: Michio Honda <micchie@sfc.wide.ad.jp>
> Date: Fri, 10 Jun 2011 16:42:14 +0900
> Subject: [PATCH] sctp: kzalloc() error handling on deleting last address
>
> Signed-off-by: Michio Honda <micchie@sfc.wide.ad.jp>
> ---
> net/sctp/socket.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index e7e1b14..a23d898 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -786,6 +786,8 @@ static int sctp_send_asconf_del_ip(struct sock *sk,
> continue;
> asoc->asconf_addr_del_pending =
> kzalloc(sizeof(union sctp_addr), GFP_ATOMIC);
> + if (asoc->asconf_addr_del_pending == NULL)
> + continue;
better to return with ENOMEM.
if (asoc->asconf_addr_del_pending == NULL) {
retval = -ENOMEM;
goto out;
}
> asoc->asconf_addr_del_pending->sa.sa_family =
> addrs->sa_family;
> asoc->asconf_addr_del_pending->v4.sin_port =
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-10 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-10 8:07 [PATCH] sctp: kzalloc() error handling on deleting last address Michio Honda
2011-06-10 8:21 ` Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).