From: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Intel Linux Wireless
<ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
Jouni Malinen <jmalinen-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
Senthil Balasubramanian
<senthilkumar-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org,
Wey-Yi Guy <wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Vasanthakumar Thiagarajan
<vasanth-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
Christian Lamparter
<chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
Stanislaw Gruszka
<sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *
Date: Tue, 14 Jun 2011 12:31:40 -0400 [thread overview]
Message-ID: <4DF78CEC.70409@gnu.org> (raw)
In-Reply-To: <337c22b774ff7f007b90b266b25c9a33ff555c48.1308024069.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On 06/14/2011 12:02 AM, Joe Perches wrote:
> /* Get the message ID */
> - msg_id = (__be16 *) ((void *) htc_hdr +
> - sizeof(struct htc_frame_hdr));
> + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);
I would never do stuff like this without verifying by sparse that no
warnings are introduced.
Sparse warnings should be avoided to keep sparse checks useful.
Otherwise, important warnings would drown in the noise.
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-14 16:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 4:02 [PATCH net-next 0/2] drivers/net: Remove casts of void * Joe Perches
2011-06-14 4:02 ` [PATCH net-next 1/2] wireless: " Joe Perches
2011-06-14 5:23 ` Julian Calaby
[not found] ` <BANLkTi=i30Rn7gpCDbn9KKJucq8CB=hssA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-14 5:32 ` Joe Perches
2011-06-14 5:39 ` Julian Calaby
2011-06-14 7:19 ` Joe Perches
2011-06-14 8:45 ` Bing Zhao
2011-06-14 8:46 ` Bing Zhao
[not found] ` <337c22b774ff7f007b90b266b25c9a33ff555c48.1308024069.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-06-14 16:31 ` Pavel Roskin [this message]
2011-06-14 16:43 ` [ath9k-devel] " Joe Perches
2011-06-14 17:43 ` Christian Lamparter
2011-06-14 4:02 ` [PATCH net-next 2/2] drivers/net: " Joe Perches
2011-06-14 7:56 ` Debashis Dutt
2011-06-14 8:18 ` Daniele Venzano
2011-06-14 9:21 ` Geert Uytterhoeven
2011-06-14 14:00 ` Joe Perches
2011-06-14 14:02 ` Geert Uytterhoeven
2011-06-14 10:34 ` Chris Snook
2011-06-14 14:17 ` Joe Perches
2011-06-14 14:22 ` Chris Snook
2011-06-15 0:10 ` Huang, Xiong
2011-06-14 11:31 ` Amit Salecha
2011-06-14 17:53 ` Sjur BRENDELAND
[not found] ` <C4E199C967B4824F9C9DF4C42CE4A3B8591B7F0D78@EXMAIL.ad.emulex.com>
2011-06-14 18:31 ` Ajit.Khaparde
2011-06-16 15:23 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF78CEC.70409@gnu.org \
--to=proski-mxxj517/zsq@public.gmane.org \
--cc=ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org \
--cc=chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
--cc=ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=jmalinen-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=senthilkumar-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org \
--cc=sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=vasanth-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org \
--cc=wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).