* [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device.
@ 2011-06-24 0:39 John Hernandez
2011-06-24 4:53 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: John Hernandez @ 2011-06-24 0:39 UTC (permalink / raw)
To: davem; +Cc: netdev, divy, jay
From: John (Jay) Hernandez <jay@chelsio.com>
Fixed call to skb_record_rx_queue where we were passing the queue index
relative to the adapter when it should have been relative to the net_device.
Signed-off-by: John (Jay) Hernandez <jay@chelsio.com>
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/sge.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 3f562ba..76bf589 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2026,7 +2026,7 @@ static void rx_eth(struct adapter *adap, struct sge_rspq *rq,
skb->ip_summed = CHECKSUM_UNNECESSARY;
} else
skb_checksum_none_assert(skb);
- skb_record_rx_queue(skb, qs - &adap->sge.qs[0]);
+ skb_record_rx_queue(skb, qs - &adap->sge.qs[pi->first_qset]);
if (unlikely(p->vlan_valid)) {
struct vlan_group *grp = pi->vlan_grp;
@@ -2145,7 +2145,7 @@ static void lro_add_page(struct adapter *adap, struct sge_qset *qs,
if (!complete)
return;
- skb_record_rx_queue(skb, qs - &adap->sge.qs[0]);
+ skb_record_rx_queue(skb, qs - &adap->sge.qs[pi->first_qset]);
if (unlikely(cpl->vlan_valid)) {
struct vlan_group *grp = pi->vlan_grp;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device.
2011-06-24 0:39 [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device John Hernandez
@ 2011-06-24 4:53 ` Eric Dumazet
2011-06-24 5:27 ` Divy Le Ray
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2011-06-24 4:53 UTC (permalink / raw)
To: John Hernandez; +Cc: davem, netdev, divy, Shawn Bohrer
Le jeudi 23 juin 2011 à 17:39 -0700, John Hernandez a écrit :
> From: John (Jay) Hernandez <jay@chelsio.com>
>
> Fixed call to skb_record_rx_queue where we were passing the queue index
> relative to the adapter when it should have been relative to the net_device.
>
> Signed-off-by: John (Jay) Hernandez <jay@chelsio.com>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>
Hmm, wasnt this bug reported by Shawn Bohrer ?
Reported-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
Proper credits please ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device.
2011-06-24 4:53 ` Eric Dumazet
@ 2011-06-24 5:27 ` Divy Le Ray
2011-06-25 1:04 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Divy Le Ray @ 2011-06-24 5:27 UTC (permalink / raw)
To: Eric Dumazet; +Cc: John Hernandez, davem, netdev, Shawn Bohrer
On 6/23/2011 9:53 PM, Eric Dumazet wrote:
> Le jeudi 23 juin 2011 à 17:39 -0700, John Hernandez a écrit :
>> From: John (Jay) Hernandez<jay@chelsio.com>
>>
>> Fixed call to skb_record_rx_queue where we were passing the queue index
>> relative to the adapter when it should have been relative to the net_device.
>>
>> Signed-off-by: John (Jay) Hernandez<jay@chelsio.com>
>> Signed-off-by: Divy Le Ray<divy@chelsio.com>
>>
> Hmm, wasnt this bug reported by Shawn Bohrer ?
Yes, it was.
> Reported-by: Shawn Bohrer<sbohrer@rgmadvisors.com>
>
> Proper credits please ?
Thanks for fixing this.
cheers,
Divy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device.
2011-06-24 5:27 ` Divy Le Ray
@ 2011-06-25 1:04 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-06-25 1:04 UTC (permalink / raw)
To: divy; +Cc: eric.dumazet, jay, netdev, sbohrer
From: Divy Le Ray <divy@chelsio.com>
Date: Thu, 23 Jun 2011 22:27:18 -0700
> On 6/23/2011 9:53 PM, Eric Dumazet wrote:
>> Le jeudi 23 juin 2011 à 17:39 -0700, John Hernandez a écrit :
>>> From: John (Jay) Hernandez<jay@chelsio.com>
>>>
>>> Fixed call to skb_record_rx_queue where we were passing the queue
>>> index
>>> relative to the adapter when it should have been relative to the
>>> net_device.
>>>
>>> Signed-off-by: John (Jay) Hernandez<jay@chelsio.com>
>>> Signed-off-by: Divy Le Ray<divy@chelsio.com>
>>>
>> Hmm, wasnt this bug reported by Shawn Bohrer ?
>
> Yes, it was.
>> Reported-by: Shawn Bohrer<sbohrer@rgmadvisors.com>
>>
>> Proper credits please ?
>
> Thanks for fixing this.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-25 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-24 0:39 [PATCH net-2.6] cxgb3: skb_record_rx_queue now records the queue index relative to the net_device John Hernandez
2011-06-24 4:53 ` Eric Dumazet
2011-06-24 5:27 ` Divy Le Ray
2011-06-25 1:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).