From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] ssb: use pci_dev->revision
Date: Fri, 24 Jun 2011 15:20:11 +0400 [thread overview]
Message-ID: <4E0472EB.8060009@mvista.com> (raw)
In-Reply-To: <20110623173204.00fbaed6@maggie>
Hello.
On 23-06-2011 19:32, Michael Büsch wrote:
>>>> The bus scan code reads PCI revision ID from the PCI configuration register
>>>> while it's already stored by PCI subsystem in the 'revision' field of 'struct
>>>> pci_dev'...
>>>> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>>>> ---
>>>> The patch is against the recent Linus' tree.
>>>> There's another place where the revision ID register is read but as 16-bit
>>>> entity (probably by mistake though), so I didn't convert it...
>>> Where is that?
>> drivers/ssb/pci.c, line 741.
> Yes that probably is by mistake. Can you convert it as well, please?
Tnen that whole function needs to be converted, as it reads subsystrem ID
from the PCI config. space, while it's aready stored by PCI core. That is a
matter of yet another patch.
WBR, Sergei
prev parent reply other threads:[~2011-06-24 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 14:49 [PATCH] ssb: use pci_dev->revision Sergei Shtylyov
2011-06-23 15:09 ` Michael Büsch
2011-06-23 15:11 ` Sergei Shtylyov
2011-06-23 15:32 ` Michael Büsch
2011-06-24 11:20 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0472EB.8060009@mvista.com \
--to=sshtylyov@mvista.com \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).