From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for June 23 (net)
Date: Fri, 24 Jun 2011 08:38:52 -0700 [thread overview]
Message-ID: <4E04AF8C.6050007@oracle.com> (raw)
In-Reply-To: <20110623.212120.2043173528294538748.davem@davemloft.net>
On 06/23/11 21:21, David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Thu, 23 Jun 2011 09:14:29 -0700
>
>> On Thu, 23 Jun 2011 15:54:31 +1000 Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20110622:
>>>
>>> The powerpc allyesconfig (and probably others) is still broken because we
>>> now build the staging drivers and because of a commit in the net tree.
>>> The breakage in Linus' tree is fixed by one of Andrew's patches above.
>>>
>>> The net tree gained 2 build failures that I have left (see above).
>>
>>
>> When CONFIG_INET is not enabled:
>>
>> net/core/dev.c:2535: error: implicit declaration of function 'ip_is_fragment'
>
> I'll fix this like so:
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> diff --git a/include/net/ip.h b/include/net/ip.h
> index d603cd3..9fa9416 100644
> --- a/include/net/ip.h
> +++ b/include/net/ip.h
> @@ -236,6 +236,11 @@ extern void ipfrag_init(void);
>
> extern void ip_static_sysctl_init(void);
>
> +static inline bool ip_is_fragment(const struct iphdr *iph)
> +{
> + return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
> +}
> +
> #ifdef CONFIG_INET
> #include <net/dst.h>
>
> @@ -250,11 +255,6 @@ int ip_decrease_ttl(struct iphdr *iph)
> return --iph->ttl;
> }
>
> -static inline bool ip_is_fragment(const struct iphdr *iph)
> -{
> - return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
> -}
> -
> static inline
> int ip_dont_fragment(struct sock *sk, struct dst_entry *dst)
> {
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-06-24 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110623155431.6bfe3b40.sfr@canb.auug.org.au>
2011-06-23 16:14 ` linux-next: Tree for June 23 (net) Randy Dunlap
2011-06-23 17:17 ` Randy Dunlap
2011-06-23 18:13 ` Mike Frysinger
2011-06-24 4:21 ` David Miller
2011-06-24 15:38 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E04AF8C.6050007@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).