* Re: linux-next: Tree for June 23 (net)
2011-06-23 16:14 ` linux-next: Tree for June 23 (net) Randy Dunlap
@ 2011-06-23 17:17 ` Randy Dunlap
2011-06-23 18:13 ` Mike Frysinger
2011-06-24 4:21 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-06-23 17:17 UTC (permalink / raw)
To: netdev; +Cc: Stephen Rothwell, linux-next, LKML
On Thu, 23 Jun 2011 09:14:29 -0700 Randy Dunlap wrote:
> On Thu, 23 Jun 2011 15:54:31 +1000 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20110622:
> >
> > The powerpc allyesconfig (and probably others) is still broken because we
> > now build the staging drivers and because of a commit in the net tree.
> > The breakage in Linus' tree is fixed by one of Andrew's patches above.
> >
> > The net tree gained 2 build failures that I have left (see above).
>
>
> When CONFIG_INET is not enabled:
>
> net/core/dev.c:2535: error: implicit declaration of function 'ip_is_fragment'
same problem in more places:
net/sched/sch_choke.c:184: error: implicit declaration of function 'ip_is_fragment'
net/sched/cls_rsvp.h:170: error: implicit declaration of function 'ip_is_fragment'
net/sched/cls_flow.c:124: error: implicit declaration of function 'ip_is_fragment'
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for June 23 (net)
2011-06-23 16:14 ` linux-next: Tree for June 23 (net) Randy Dunlap
2011-06-23 17:17 ` Randy Dunlap
@ 2011-06-23 18:13 ` Mike Frysinger
2011-06-24 4:21 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2011-06-23 18:13 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML
On Thu, Jun 23, 2011 at 12:14, Randy Dunlap wrote:
> On Thu, 23 Jun 2011 15:54:31 +1000 Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20110622:
>>
>> The powerpc allyesconfig (and probably others) is still broken because we
>> now build the staging drivers and because of a commit in the net tree.
>> The breakage in Linus' tree is fixed by one of Andrew's patches above.
>>
>> The net tree gained 2 build failures that I have left (see above).
>
>
> When CONFIG_INET is not enabled:
>
> net/core/dev.c:2535: error: implicit declaration of function 'ip_is_fragment'
i see this on two Blackfin defconfigs like CM-BF533
-mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for June 23 (net)
2011-06-23 16:14 ` linux-next: Tree for June 23 (net) Randy Dunlap
2011-06-23 17:17 ` Randy Dunlap
2011-06-23 18:13 ` Mike Frysinger
@ 2011-06-24 4:21 ` David Miller
2011-06-24 15:38 ` Randy Dunlap
2 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-06-24 4:21 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 23 Jun 2011 09:14:29 -0700
> On Thu, 23 Jun 2011 15:54:31 +1000 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20110622:
>>
>> The powerpc allyesconfig (and probably others) is still broken because we
>> now build the staging drivers and because of a commit in the net tree.
>> The breakage in Linus' tree is fixed by one of Andrew's patches above.
>>
>> The net tree gained 2 build failures that I have left (see above).
>
>
> When CONFIG_INET is not enabled:
>
> net/core/dev.c:2535: error: implicit declaration of function 'ip_is_fragment'
I'll fix this like so:
diff --git a/include/net/ip.h b/include/net/ip.h
index d603cd3..9fa9416 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -236,6 +236,11 @@ extern void ipfrag_init(void);
extern void ip_static_sysctl_init(void);
+static inline bool ip_is_fragment(const struct iphdr *iph)
+{
+ return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
+}
+
#ifdef CONFIG_INET
#include <net/dst.h>
@@ -250,11 +255,6 @@ int ip_decrease_ttl(struct iphdr *iph)
return --iph->ttl;
}
-static inline bool ip_is_fragment(const struct iphdr *iph)
-{
- return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
-}
-
static inline
int ip_dont_fragment(struct sock *sk, struct dst_entry *dst)
{
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: linux-next: Tree for June 23 (net)
2011-06-24 4:21 ` David Miller
@ 2011-06-24 15:38 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-06-24 15:38 UTC (permalink / raw)
To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel
On 06/23/11 21:21, David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Thu, 23 Jun 2011 09:14:29 -0700
>
>> On Thu, 23 Jun 2011 15:54:31 +1000 Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20110622:
>>>
>>> The powerpc allyesconfig (and probably others) is still broken because we
>>> now build the staging drivers and because of a commit in the net tree.
>>> The breakage in Linus' tree is fixed by one of Andrew's patches above.
>>>
>>> The net tree gained 2 build failures that I have left (see above).
>>
>>
>> When CONFIG_INET is not enabled:
>>
>> net/core/dev.c:2535: error: implicit declaration of function 'ip_is_fragment'
>
> I'll fix this like so:
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> diff --git a/include/net/ip.h b/include/net/ip.h
> index d603cd3..9fa9416 100644
> --- a/include/net/ip.h
> +++ b/include/net/ip.h
> @@ -236,6 +236,11 @@ extern void ipfrag_init(void);
>
> extern void ip_static_sysctl_init(void);
>
> +static inline bool ip_is_fragment(const struct iphdr *iph)
> +{
> + return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
> +}
> +
> #ifdef CONFIG_INET
> #include <net/dst.h>
>
> @@ -250,11 +255,6 @@ int ip_decrease_ttl(struct iphdr *iph)
> return --iph->ttl;
> }
>
> -static inline bool ip_is_fragment(const struct iphdr *iph)
> -{
> - return (iph->frag_off & htons(IP_MF | IP_OFFSET)) != 0;
> -}
> -
> static inline
> int ip_dont_fragment(struct sock *sk, struct dst_entry *dst)
> {
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread