* Potential locking issue in sunrpc
@ 2011-06-30 23:12 Ben Greear
0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2011-06-30 23:12 UTC (permalink / raw)
To: netdev
This method in sched.c says we should have a lock for ASYNC
/*
* Make an RPC task runnable.
*
* Note: If the task is ASYNC, this must be called with
* the spinlock held to protect the wait queue operation.
*/
static void rpc_make_runnable(struct rpc_task *task)
However, I don't think the lock is being taken for
the call path starting with rpcb_call_async in
rpcb_clnt.c:
rpcb_call_async
rpc_run_task
rpc_execute
rpc_make_runnable
Is the comment on the make_runnable method wrong, or are we missing locking?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-30 23:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-30 23:12 Potential locking issue in sunrpc Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).