netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] netpoll: Trivial updates
Date: Fri, 01 Jul 2011 11:26:56 +0800	[thread overview]
Message-ID: <4E0D3E80.5080209@redhat.com> (raw)
In-Reply-To: <cover.1309482314.git.joe@perches.com>

于 2011年07月01日 09:08, Joe Perches 写道:
> cc: WANG Cong<amwang@redhat.com>
>
> Joe Perches (2):
>    netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev
>    netpoll: Remove trivial wrapper function netpoll_poll
>
>   include/linux/netpoll.h |    2 --
>   net/core/netpoll.c      |   13 +++----------
>   2 files changed, 3 insertions(+), 12 deletions(-)
>

I am fine with patch 1/2, but not 2/2, since it is trivial,
why touch it? With netpoll_poll(), we don't need to explore the
details of struct netpoll, I think it is nice to have it.

BTW, you can kill the export of netpoll_send_skb_on_dev() too.

Thanks.

  parent reply	other threads:[~2011-07-01  3:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  1:08 [PATCH 0/2] netpoll: Trivial updates Joe Perches
2011-07-01  1:08 ` [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev Joe Perches
2011-07-04  3:02   ` David Miller
2011-07-04  6:53   ` Harry Wei
2011-07-04  7:46     ` Joe Perches
2011-07-04  9:27       ` Harry Wei
2011-07-01  1:08 ` [PATCH 2/2] netpoll: Remove wrapper function netpoll_poll Joe Perches
2011-07-04  3:02   ` David Miller
2011-07-01  3:26 ` Cong Wang [this message]
2011-07-01  3:35   ` [PATCH 0/2] netpoll: Trivial updates Joe Perches
2011-07-01  3:49     ` Cong Wang
2011-07-01  3:55       ` Joe Perches
2011-07-01  4:00         ` Cong Wang
2011-07-01  4:03           ` Joe Perches
2011-07-01  4:05             ` Cong Wang
2011-07-01  7:06       ` David Miller
2011-07-01 22:18         ` Joe Perches
2011-07-01 22:31           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0D3E80.5080209@redhat.com \
    --to=amwang@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).