From: Cong Wang <amwang@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] netpoll: Trivial updates
Date: Fri, 01 Jul 2011 12:00:17 +0800 [thread overview]
Message-ID: <4E0D4651.7000005@redhat.com> (raw)
In-Reply-To: <1309492522.7277.25.camel@Joe-Laptop>
于 2011年07月01日 11:55, Joe Perches 写道:
> On Fri, 2011-07-01 at 11:49 +0800, Cong Wang wrote:
>> 于 2011年07月01日 11:35, Joe Perches 写道:
>>>> BTW, you can kill the export of netpoll_send_skb_on_dev() too.
>>> Not too sure about that.
>>> It's used in netpoll.h by netpoll_send_skb.
>>> It could be called from anywhere.
>>> It's currently called/used by bonding.h.
>> % git grep netpoll_send_skb_on_dev .
>> include/linux/netpoll.h:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
>> include/linux/netpoll.h: netpoll_send_skb_on_dev(np, skb, np->dev);
>> net/core/netpoll.c:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
>> net/core/netpoll.c:EXPORT_SYMBOL(netpoll_send_skb_on_dev);
>> No modules use it...
>
> Read what I wrote.
>
> Look up one level at where it's used by netpoll.h.
>
Then move netpoll_send_skb(), export it instead of netpoll_send_skb_on_dev()...
next prev parent reply other threads:[~2011-07-01 4:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 1:08 [PATCH 0/2] netpoll: Trivial updates Joe Perches
2011-07-01 1:08 ` [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-04 6:53 ` Harry Wei
2011-07-04 7:46 ` Joe Perches
2011-07-04 9:27 ` Harry Wei
2011-07-01 1:08 ` [PATCH 2/2] netpoll: Remove wrapper function netpoll_poll Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-01 3:26 ` [PATCH 0/2] netpoll: Trivial updates Cong Wang
2011-07-01 3:35 ` Joe Perches
2011-07-01 3:49 ` Cong Wang
2011-07-01 3:55 ` Joe Perches
2011-07-01 4:00 ` Cong Wang [this message]
2011-07-01 4:03 ` Joe Perches
2011-07-01 4:05 ` Cong Wang
2011-07-01 7:06 ` David Miller
2011-07-01 22:18 ` Joe Perches
2011-07-01 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0D4651.7000005@redhat.com \
--to=amwang@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).