From: Cong Wang <amwang@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [rfc] Remove member .name from struct netpoll
Date: Mon, 04 Jul 2011 10:07:00 +0800 [thread overview]
Message-ID: <4E112044.8050904@redhat.com> (raw)
In-Reply-To: <1309540071.7277.63.camel@Joe-Laptop>
于 2011年07月02日 01:07, Joe Perches 写道:
> struct netpoll has member .name
>
> struct netpoll {
> struct net_device *dev;
> char dev_name[IFNAMSIZ];
> const char *name;
> [...]
> };
>
> that is set only by netconsole.c
>
> static struct netconsole_target *alloc_param_target(char *target_config)
> {
> [...]
> nt->np.name = "netconsole";
>
> and used only by net/core/netpoll.c to emit "netconsole: " on
> logging messages.
>
Probably this is due to that in history netdump was another user of it.
>
> Are there out of tree users or plans to use "struct netpoll"
> by other modules?
>
AFAIK, netoops will use it too, see
https://lkml.org/lkml/2010/11/2/299
Cc'ing Matt in case I miss something...
Thanks.
prev parent reply other threads:[~2011-07-04 2:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 17:07 [rfc] Remove member .name from struct netpoll Joe Perches
2011-07-04 2:07 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E112044.8050904@redhat.com \
--to=amwang@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).