* [PATCH 1/2] net: sh_eth: fix cannot work half-duplex mode
@ 2011-07-06 6:33 Yoshihiro Shimoda
2011-07-06 6:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yoshihiro Shimoda @ 2011-07-06 6:33 UTC (permalink / raw)
To: davem; +Cc: netdev, SH-Linux
When link was down, the bit of DM in ECMR was always set.
So, we could not use half-duplex mode on the controller.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/net/sh_eth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 09b5aa8..c08d9e1 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -1185,8 +1185,8 @@ static void sh_eth_adjust_link(struct net_device *ndev)
mdp->cd->set_rate(ndev);
}
if (mdp->link == PHY_DOWN) {
- sh_eth_write(ndev, (sh_eth_read(ndev, ECMR) & ~ECMR_TXF)
- | ECMR_DM, ECMR);
+ sh_eth_write(ndev,
+ (sh_eth_read(ndev, ECMR) & ~ECMR_TXF), ECMR);
new_state = 1;
mdp->link = phydev->link;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] net: sh_eth: fix cannot work half-duplex mode
2011-07-06 6:33 [PATCH 1/2] net: sh_eth: fix cannot work half-duplex mode Yoshihiro Shimoda
@ 2011-07-06 6:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-07-06 6:42 UTC (permalink / raw)
To: yoshihiro.shimoda.uh; +Cc: netdev, linux-sh
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date: Wed, 06 Jul 2011 15:33:51 +0900
> When link was down, the bit of DM in ECMR was always set.
> So, we could not use half-duplex mode on the controller.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-06 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-06 6:33 [PATCH 1/2] net: sh_eth: fix cannot work half-duplex mode Yoshihiro Shimoda
2011-07-06 6:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).