From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>
Cc: nicolas.2p.debian@free.fr, fubar@us.ibm.com, andy@greyhouse.net,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] bonding: document two undocumented options.
Date: Wed, 03 Aug 2011 22:01:11 +0200 [thread overview]
Message-ID: <4E39A907.5040408@gmail.com> (raw)
In-Reply-To: <20110803.034425.1421983987148421662.davem@davemloft.net>
Le 03/08/2011 12:44, David Miller a écrit :
> From: Nicolas de Pesloüan<nicolas.2p.debian@free.fr>
> Date: Tue, 2 Aug 2011 22:06:55 +0200
>
>> Commit 655f8919d549ad1872e24d826b6ce42530516d2e
>> bonding: add min links parameter to 802.3ad
>>
>> and commit ebd8e4977a87cb81d93c62a9bff0102a9713722f
>> bonding: add all_slaves_active parameter
>>
>> introduced new options to bonding, but didn't provide the documentation
>> for those options.
>>
>> Signed-off-by: Nicolas de Pesloüan<nicolas.2p.debian@free.fr>
>
> Please explicitly mention in each new entry what the default
> setting is.
Unfortunately, I failed to find a place in the bonding code where the max_links option is
initialized with a default value. So I must assume default value is zero which should cause carrier
to always be asserted, or undefined, which should cause interesting side effects...
The obvious default value should be 1, but I cannot confirm it is.
Stephen, as the author of this feature, can you please clarify what the default value for min_links is?
V2 will follow, giving the real default value for all_slaves_active and what I consider the sensible
default value for max_links, even if the technical real default value is currently unclear.
Nicolas.
next prev parent reply other threads:[~2011-08-03 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:06 [PATCH] bonding: document two undocumented options Nicolas de Pesloüan
2011-08-03 6:43 ` bonding and ifenslave version Nicolas de Pesloüan
2011-08-03 19:03 ` Andy Gospodarek
2011-08-03 19:38 ` Nicolas de Pesloüan
2011-08-03 20:07 ` Jay Vosburgh
2011-08-03 20:38 ` Nicolas de Pesloüan
2011-08-03 21:33 ` Stephen Hemminger
2011-08-04 5:31 ` Nicolas de Pesloüan
2011-08-04 16:57 ` Stephen Hemminger
2011-08-04 21:20 ` Nicolas de Pesloüan
2011-08-03 10:44 ` [PATCH] bonding: document two undocumented options David Miller
2011-08-03 20:01 ` Nicolas de Pesloüan [this message]
2011-08-03 20:59 ` Jay Vosburgh
2011-08-04 5:41 ` Nicolas de Pesloüan
2011-08-06 17:06 ` [PATCH v3] " Nicolas de Pesloüan
2011-08-08 5:16 ` David Miller
2011-08-03 20:02 ` [PATCH] " Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E39A907.5040408@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).