From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source. Date: Tue, 09 Aug 2011 10:13:08 +0200 Message-ID: <4E40EC14.1010005@pengutronix.de> References: <1312641270-6018-1-git-send-email-holt@sgi.com> <1312641270-6018-6-git-send-email-holt@sgi.com> <4E3FA066.3020301@grandegger.com> <20110808113136.GS4926@sgi.com> <4E3FDFC9.7080508@grandegger.com> <20110808135630.GU4926@sgi.com> <4E3FEFBB.9050103@grandegger.com> <20110808142153.GW4926@sgi.com> <4E3FF4B8.2010603@grandegger.com> <20110808144424.GY4926@sgi.com> <4E3FF9EA.6030601@grandegger.com> <4E3FFD5B.7080000@pengutronix.de> <4E4001E1.3030508@grandegger.com> <4E403097.4020306@pengutronix.de> <9C64B7751C3BCA41B64A68E23005A7BE1B9D6C@039-SN1MPN1-002.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4414895774163719981==" Cc: "socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Wolfgang Grandegger To: U Bhaskar-B22300 Return-path: In-Reply-To: <9C64B7751C3BCA41B64A68E23005A7BE1B9D6C-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============4414895774163719981== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFC50D7FD5A1E705378E2776C" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFC50D7FD5A1E705378E2776C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 08/09/2011 09:57 AM, U Bhaskar-B22300 wrote: >> On 08/08/2011 05:33 PM, Wolfgang Grandegger wrote: >>>> ACK - The device tree bindings as in mainline's Documentation is a >> mess. >>>> If the powerpc guys are happy with a clock interfaces based approach= >>>> somewhere in arch/ppc, I'm more than happy to remove: >>>> - fsl,flexcan-clock-source (not implemented, even in the fsl driver)= > [Bhaskar]I have pushed the FlexCAN series of patches, It contains the > usage of all the fields posted in the FlexCAN bindings at=20 > http://git.kernel.org/?p=3Dlinux/kernel/git/stable/linux-3.0.y.git;a=3D= blob;f=3DDocumentation/devicetree/bindings/net/can/fsl-flexcan.txt;h=3D1a= 729f089866259ef82d0db5893ff7a8c54d5ccf;hb=3D94ed5b4788a7cdbe68bc7cb851697= 2cbebdc8274 I've commented the patches. They are in a very bad shape. Please test Robin's patches. >>>> >>>> - fsl,flexcan-clock-divider \__ replace with code in arch/ppc, or >>>> - clock-frequency / a single clock-frequency attribute >>> >>> In the "net-next-2.6" tree there is also: >>> >>> $ grep flexcan arch/powerpc/boots/dts/*.dts >>> p1010rdb.dts: fsl,flexcan-clock-source =3D "platform"; >>> p1010rdb.dts: fsl,flexcan-clock-source =3D "platform"; >>> p1010si.dtsi: compatible =3D "fsl,flexcan-v1.0"; >>> p1010si.dtsi: fsl,flexcan-clock-divider =3D <2>; >>> p1010si.dtsi: compatible =3D "fsl,flexcan-v1.0"; >>> p1010si.dtsi: fsl,flexcan-clock-divider =3D <2>; >>> >>> Especially the fsl,flexcan-clock-divider =3D <2>; might make people >>> think, that they could set something else. >> > [Bhaskar] As it is mentioned in the Flexcan bindings, the need of > fsl,flexcan-clock-divider =3D <2>; But I kept it as "2" because FlexCan= > clock source is the platform clock and it is CCB/2 If the "2" is > misleading, the bindings can be changed or some text can be written > to make the meaning of "2" Understandable , Please suggest .. The clock devider is crap. Why not specify the clockrate that goes into the flexcan core? cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigFC50D7FD5A1E705378E2776C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5A7BcACgkQjTAFq1RaXHOENQCcC4gkWrYTqALE/OylH2Bomcuo In8AoJhC/T/DLjfwZyYXoRgu07pDbPPj =OdL7 -----END PGP SIGNATURE----- --------------enigFC50D7FD5A1E705378E2776C-- --===============4414895774163719981== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Socketcan-core mailing list Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org https://lists.berlios.de/mailman/listinfo/socketcan-core --===============4414895774163719981==--