From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, matvejchikov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] slip: fix NOHZ local_softirq_pending 08 warning
Date: Wed, 10 Aug 2011 16:33:28 +0200 [thread overview]
Message-ID: <4E4296B8.1090806@hartkopp.net> (raw)
In-Reply-To: <20110810102824.4c4eaefe@lxorguk.ukuu.org.uk>
On 10.08.2011 11:28, Alan Cox wrote:
>> 2) From tty_flip_buffer_push() which schedules the flush_to_ldisc to
>> work or calls it directly if the tty->low_latency set.
>>
>> So the only thing we must take into account that with tty->low_latency
>> set we can be in IRQ context when doing with netif_rx_ni(). But if we
>
> A driver is not permitted to directly call into flush_to_ldisc from an
> interrupt so that case doesn't happen.
>
Thanks to both of you for the explanation!
I'll send a patch for slcan.c then.
Best regards,
Oliver
prev parent reply other threads:[~2011-08-10 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 19:23 [PATCH] slip: fix NOHZ local_softirq_pending 08 warning Matvejchikov Ilya
2011-08-08 5:14 ` David Miller
2011-08-09 17:07 ` Oliver Hartkopp
2011-08-10 7:47 ` Matvejchikov Ilya
2011-08-10 9:28 ` Alan Cox
2011-08-10 14:33 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4296B8.1090806@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=matvejchikov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).