From: Avi Kivity <avi@redhat.com>
To: Brad Campbell <lists2009@fnarfbargle.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, CaT <cat@zip.com.au>,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
netdev <netdev@vger.kernel.org>
Subject: Re: KVM induced panic on 2.6.38[2367] & 2.6.39
Date: Mon, 22 Aug 2011 09:36:04 +0300 [thread overview]
Message-ID: <4E51F8D4.5070804@redhat.com> (raw)
In-Reply-To: <4E4FB3B7.4040501@fnarfbargle.com>
On 08/20/2011 04:16 PM, Brad Campbell wrote:
> Author: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Thu Jul 1 13:28:27 2010 +0000
>
> x86: Drop CONFIG_MCORE2 check around setting of NET_IP_ALIGN
>
> This patch removes the CONFIG_MCORE2 check from around
> NET_IP_ALIGN. It is
> based on a suggestion from Andi Kleen. The assumption is that
> there are
> not any x86 cores where unaligned access is really slow, and this
> change
> would allow for a performance improvement to still exist on
> configurations
> that are not necessarily optimized for Core 2.
>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Acked-by: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> :040000 040000 5a15867789080a2f67a74b17c4422f85b7a9fb4a
> b98769348bd765731ca3ff03b33764257e23226c M arch
>
> I can confirm this bug exists in the 3.0 kernel, however I'm unable to
> reproduce it on todays git.
>
> So anyone using netfilter, kvm and bridge on kernels between
> 2.6.36-rc1 and 3.0 may hit this bug, but it looks like it is fixed in
> the current 3.1-rc kernels.
>
Thanks for this effort. I don't think this patch is buggy in itself, it
merely exposed another bug which was fixed later on.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-08-22 6:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DE44333.9000903@fnarfbargle.com>
[not found] ` <20110531054729.GA16852@liondog.tnic>
[not found] ` <4DE4B432.1090203@fnarfbargle.com>
[not found] ` <20110531103808.GA6915@eferding.osrc.amd.com>
[not found] ` <4DE4FA2B.2050504@fnarfbargle.com>
[not found] ` <alpine.LSU.2.00.1105311517480.21107@sister.anvils>
[not found] ` <4DE589C5.8030600@fnarfbargle.com>
[not found] ` <20110601011527.GN19505@random.random>
[not found] ` <alpine.LSU.2.00.1105312120530.22808@sister.anvils>
[not found] ` <4DE5DCA8.7070704@fnarfbargle.com>
[not found] ` <4DE5E29E.7080009@redhat.com>
[not found] ` <4DE60669.9050606@fnarfbargle.com>
[not found] ` <4DE60918.3010008@redhat.com>
[not found] ` <4DE60940.1070107@redhat.com>
[not found] ` <4DE61A2B.7000008@fnarfbargle.com>
2011-06-01 11:09 ` KVM induced panic on 2.6.38[2367] & 2.6.39 Avi Kivity
2011-06-01 11:18 ` CaT
2011-06-01 11:52 ` Brad Campbell
2011-06-01 23:03 ` CaT
2011-06-03 13:38 ` Brad Campbell
2011-06-03 15:50 ` Bernhard Held
2011-06-03 16:07 ` Brad Campbell
2011-06-06 20:10 ` Bart De Schuymer
2011-06-06 20:23 ` Eric Dumazet
2011-06-07 3:33 ` Brad Campbell
2011-06-07 13:30 ` Patrick McHardy
2011-06-07 14:40 ` Brad Campbell
2011-06-07 15:35 ` Patrick McHardy
2011-06-07 18:31 ` Eric Dumazet
2011-06-07 22:57 ` Patrick McHardy
2011-06-08 0:18 ` Brad Campbell
2011-06-08 3:59 ` Eric Dumazet
2011-06-08 17:02 ` Brad Campbell
2011-06-08 21:22 ` Eric Dumazet
2011-06-10 2:52 ` Simon Horman
2011-06-10 12:37 ` Mark Lord
2011-06-10 16:43 ` Henrique de Moraes Holschuh
2011-06-12 15:38 ` Avi Kivity
2011-06-07 23:43 ` Brad Campbell
2011-06-07 18:04 ` Bart De Schuymer
2011-06-08 0:15 ` Brad Campbell
2011-06-05 8:14 ` Avi Kivity
2011-06-05 13:45 ` Brad Campbell
2011-06-05 13:58 ` Avi Kivity
2011-06-06 20:22 ` Eric Dumazet
2011-06-07 13:27 ` Brad Campbell
2011-06-07 13:37 ` Eric Dumazet
2011-06-07 15:15 ` Brad Campbell
2011-08-20 13:16 ` Brad Campbell
2011-08-22 6:36 ` Avi Kivity [this message]
2011-08-22 6:45 ` Eric Dumazet
2011-08-22 11:45 ` Brad Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E51F8D4.5070804@redhat.com \
--to=avi@redhat.com \
--cc=bp@alien8.de \
--cc=cat@zip.com.au \
--cc=eric.dumazet@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists2009@fnarfbargle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).