From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: ML netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] stmmac: remove the STBus bridge setting from the GMAC code
Date: Thu, 25 Aug 2011 10:01:46 +0200 [thread overview]
Message-ID: <4E56016A.8060709@st.com> (raw)
In-Reply-To: <1314021507-26955-1-git-send-email-peppe.cavallaro@st.com>
Hello David
you can discard this because I'm resending it in a bundle of patches to
update the whole driver to the Aug_2011 version.
Peppe
On 8/22/2011 3:58 PM, Giuseppe CAVALLARO wrote:
> This patch removes a piece of code (actually commented)
> only useful for some ST platforms in the past.
>
> This kind of setting now can be done by using the platform
> callbacks provided in linux/stmmac.h (see the stmmac.txt for
> further details).
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/stmmac/dwmac1000_core.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/stmmac/dwmac1000_core.c b/drivers/net/stmmac/dwmac1000_core.c
> index 0f63b3c..eea184a 100644
> --- a/drivers/net/stmmac/dwmac1000_core.c
> +++ b/drivers/net/stmmac/dwmac1000_core.c
> @@ -37,9 +37,6 @@ static void dwmac1000_core_init(void __iomem *ioaddr)
> value |= GMAC_CORE_INIT;
> writel(value, ioaddr + GMAC_CONTROL);
>
> - /* STBus Bridge Configuration */
> - /*writel(0xc5608, ioaddr + 0x00007000);*/
> -
> /* Freeze MMC counters */
> writel(0x8, ioaddr + GMAC_MMC_CTRL);
> /* Mask GMAC interrupts */
prev parent reply other threads:[~2011-08-25 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:58 [PATCH] stmmac: remove the STBus bridge setting from the GMAC code Giuseppe CAVALLARO
2011-08-25 8:01 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E56016A.8060709@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).