From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH 3/5] SUNRPC: make RPC service dependable on rpcbind clients creation Date: Thu, 25 Aug 2011 14:18:24 +0400 Message-ID: <4E562170.1090000@parallels.com> References: <20110824183304.4924.94670.stgit@localhost6.localdomain6> <20110824183359.4924.94364.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bfields@fieldses.org" , "davem@davemloft.net" To: "Trond.Myklebust@netapp.com" Return-path: In-Reply-To: <20110824183359.4924.94364.stgit@localhost6.localdomain6> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This patch has a flaw: rpcbind clients have to be put in case of error = in __svc_create(). So will be the second version. 24.08.2011 22:33, Stanislav Kinsbursky =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > We create or increase users counter of rcbind clients during RPC serv= ice > creation and decrease this counter (and possibly destroy those client= s) on RPC > service destruction. > > Signed-off-by: Stanislav Kinsbursky > > --- > include/linux/sunrpc/clnt.h | 2 ++ > net/sunrpc/rpcb_clnt.c | 2 +- > net/sunrpc/svc.c | 5 +++++ > 3 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/include/linux/sunrpc/clnt.h b/include/linux/sunrpc/clnt.= h > index db7bcaf..65a8115 100644 > --- a/include/linux/sunrpc/clnt.h > +++ b/include/linux/sunrpc/clnt.h > @@ -135,10 +135,12 @@ void rpc_shutdown_client(struct rpc_clnt *); > void rpc_release_client(struct rpc_clnt *); > void rpc_task_release_client(struct rpc_task *); > > +int rpcb_create_local(void); > int rpcb_register(u32, u32, int, unsigned short); > int rpcb_v4_register(const u32 program, const u32 version, > const struct sockaddr *address, > const char *netid); > +void rpcb_put_local(void); > void rpcb_getport_async(struct rpc_task *); > > void rpc_call_start(struct rpc_task *); > diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c > index b4cc0f1..437ec60 100644 > --- a/net/sunrpc/rpcb_clnt.c > +++ b/net/sunrpc/rpcb_clnt.c > @@ -318,7 +318,7 @@ out: > * Returns zero on success, otherwise a negative errno value > * is returned. > */ > -static int rpcb_create_local(void) > +int rpcb_create_local(void) > { > static DEFINE_MUTEX(rpcb_create_local_mutex); > int result =3D 0; > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c > index 6a69a11..0df8532 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -367,6 +367,9 @@ __svc_create(struct svc_program *prog, unsigned i= nt bufsize, int npools, > unsigned int xdrsize; > unsigned int i; > > + if (rpcb_create_local()< 0) > + return NULL; > + > if (!(serv =3D kzalloc(sizeof(*serv), GFP_KERNEL))) > return NULL; > serv->sv_name =3D prog->pg_name; > @@ -491,6 +494,8 @@ svc_destroy(struct svc_serv *serv) > svc_unregister(serv); > kfree(serv->sv_pools); > kfree(serv); > + > + rpcb_put_local(); > } > EXPORT_SYMBOL_GPL(svc_destroy); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 Best regards, Stanislav Kinsbursky