From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/9] stmmac: add MMC supports exported via debugfs.
Date: Mon, 29 Aug 2011 14:00:56 +0200 [thread overview]
Message-ID: <4E5B7F78.4030803@st.com> (raw)
In-Reply-To: <20110826.121222.1125604441814245954.davem@davemloft.net>
On 8/26/2011 6:12 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Thu, 25 Aug 2011 10:00:23 +0200
>
>> This patch adds the MMC management counters support.
>> MMC module is an extension of the register address
>> space and all the hardware counters can be accessed
>> via debugfs.
>> Below an example of the output:
>
> This is not the appropriate way to expose internal chip counters.
>
> Please use ethtool statistics for this.
Yes I'll do that and resend all the patches again.
Thanks for the review.
Peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-08-29 12:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 8:00 [PATCH 0/9] update the stmmac to the version Aug_2011 Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 1/9] stmmac: remove the STBus bridge setting from the GMAC code Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 2/9] stmmac: remove the mmc code Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 3/9] stmmac: add MMC supports exported via debugfs Giuseppe CAVALLARO
2011-08-26 16:12 ` David Miller
2011-08-29 12:00 ` Giuseppe CAVALLARO [this message]
2011-08-25 8:00 ` [PATCH 4/9] stmmac: export DMA TX/RX rings " Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 5/9] stmmac: support wake up irq from external sources Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 6/9] stmmac: rework the code to get the Synopsys ID Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 7/9] stmmac: add HW DMA feature register Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 8/9] stmmac: update the doc with new info about the driver's debug Giuseppe CAVALLARO
2011-08-25 8:00 ` [PATCH 9/9] stmmac: update the driver version (Aug_2011) Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B7F78.4030803@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).