From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Rajan Aggarwal <rajan.aggarwal85@gmail.com>
Cc: Urs Thuermann <urs.thuermann@volkswagen.de>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync
Date: Wed, 31 Aug 2011 19:28:02 +0200 [thread overview]
Message-ID: <4E5E6F22.4060206@hartkopp.net> (raw)
In-Reply-To: <1314784658-23938-1-git-send-email-rajan.aggarwal85@gmail.com>
On 31.08.2011 11:57, Rajan Aggarwal wrote:
> From: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
>
> This is important for SMP platform to check if timer function is
> executing on other CPU with deleting the timer.
>
> Signed-off-by: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
> ---
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tnx Rajan.
> net/can/af_can.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/can/af_can.c b/net/can/af_can.c
> index 8ce926d..9b0c32a 100644
> --- a/net/can/af_can.c
> +++ b/net/can/af_can.c
> @@ -857,7 +857,7 @@ static __exit void can_exit(void)
> struct net_device *dev;
>
> if (stats_timer)
> - del_timer(&can_stattimer);
> + del_timer_sync(&can_stattimer);
>
> can_remove_proc();
>
next prev parent reply other threads:[~2011-08-31 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 9:57 [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync Rajan Aggarwal
2011-08-31 17:28 ` Oliver Hartkopp [this message]
2011-09-15 19:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5E6F22.4060206@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rajan.aggarwal85@gmail.com \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox