Re: [patch 1/1] r8169 driver: corega support

[Darren Salt <linux@youmustbejoking.demon.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

I demand that Francois Romieu may or may not have written...

> akpm@osdl.org <akpm@osdl.org> :
> [Corega adapter support]

> It's queued in the r8169 branch at:

> git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169

> I have sent Jeff a pull request for it (and I'll probably send one
> more for the patch below).

> Darren, can you check if the patch below fixes you link detection
> issue ?

It does, but the patch causes the module to report that the reset failed even
after reporting that it's done. A fix for this is attached.

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Generate power using sun, wind, water, nuclear.      FORGET COAL AND OIL.

Life is what happens when you're busy making other plans.

[-- Attachment #2: r8169-PHY-reset-report-fix.patch --]
[-- Type: text/plain, Size: 492 bytes --]

Avoid reporting that the PHY reset has failed when it's just succeeded.

Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>

diff a/drivers/net/r8169.c b/drivers/net/r8169.c
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1452,7 +1452,7 @@ static void rtl8169_release_board(struct
 	for (i = 0; i < 100; i++) {
 		if (!tp->phy_reset_pending(ioaddr)) {
 			printk(KERN_INFO "%s: PHY reset done.\n", dev->name);
-			break;
+			return;
 		}
 		msleep(1);
 	}