* Question regarding wanrouter module
@ 2011-09-23 9:34 Holger Hans Peter Freyther
2011-09-23 11:26 ` Francois Romieu
0 siblings, 1 reply; 2+ messages in thread
From: Holger Hans Peter Freyther @ 2011-09-23 9:34 UTC (permalink / raw)
To: netdev
Hi all,
at some point the Sangoma wanrouter and device drivers were merged in the
kernel. Somewhere in 2006 (8db60bcf3021921e2d10d158641792d640e52fe8) the
drivers were removed as Sangoma wanted to maintain them themselves. Later some
of the functionality got removed (ce0ecd594d78710422599918a608). In the kernel
it appears that cycx_x25.c and isdn_x25iface.c make use of the wanrouter.
Fast forward to today, Sangoma provides a wanrouter.ko as well (they didn't
bother to change the symbol names or module name). I wonder if there are any
plans to improve the situation, e.g. rename the kernel module, change symbols,
or if there would be objections to trying to add functionality to the kernel
wanrouter.ko again?
cheers
holger
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question regarding wanrouter module
2011-09-23 9:34 Question regarding wanrouter module Holger Hans Peter Freyther
@ 2011-09-23 11:26 ` Francois Romieu
0 siblings, 0 replies; 2+ messages in thread
From: Francois Romieu @ 2011-09-23 11:26 UTC (permalink / raw)
To: Holger Hans Peter Freyther; +Cc: netdev
Holger Hans Peter Freyther <holger@freyther.de> :
[...]
> Fast forward to today, Sangoma provides a wanrouter.ko as well (they didn't
> bother to change the symbol names or module name). I wonder if there are any
> plans to improve the situation, e.g. rename the kernel module, change symbols,
> or if there would be objections to trying to add functionality to the kernel
> wanrouter.ko again ?
There are objections to adding.
The kernel wanrouter code is almost empty. Afaiu it mostly contains a
wan setup API.
Is there a reason why the added functionalities could not go through the
generic hdlc kernel code (see drivers/net/wan/hdlc*) ?
--
Ueimor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 9:34 Question regarding wanrouter module Holger Hans Peter Freyther
2011-09-23 11:26 ` Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).