From: Oliver Hartkopp <socketcan@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, stable@kernel.org, nautsch@gmail.com
Subject: Re: [PATCH net/stable] can bcm: fix tx_setup off-by-one errors
Date: Thu, 29 Sep 2011 09:46:46 +0200 [thread overview]
Message-ID: <4E842266.9090407@hartkopp.net> (raw)
In-Reply-To: <20110929.003317.223715542181691202.davem@davemloft.net>
On 09/29/11 06:33, David Miller wrote:
> From: Oliver Hartkopp <socketcan@hartkopp.net>
> Date: Fri, 23 Sep 2011 20:23:47 +0200
>
>> This patch fixes two off-by-one errors that canceled each other out.
>> Checking for the same condition two times in bcm_tx_timeout_tsklet() reduced
>> the count of frames to be sent by one. This did not show up the first time
>> tx_setup is invoked as an additional frame is sent due to TX_ANNONCE.
>> Invoking a second tx_setup on the same item led to a reduced (by 1) number of
>> sent frames.
>>
>> Reported-by: Andre Naujoks <nautsch@gmail.com>
>> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>
> Applied, and queued up for -stable.
Hello Dave,
when backporting the patch to an older kernel we discovered a problem this
patch is introducing - which causes a new regression :-(
Could you please revert this patch and dequeue it from stable?
We'll send a new patch for net-next as this fix changes/repairs the behaviour
of the count variable. Therefore it's probably better to have a fixed Kernel
version where the fix emerges. Or should we better not fix it at all and
document it in 'know bugs' ?
Sorry for that noise ...
Thanks,
Oliver
next prev parent reply other threads:[~2011-09-29 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 18:23 [PATCH net/stable] can bcm: fix tx_setup off-by-one errors Oliver Hartkopp
2011-09-27 21:09 ` Andre Naujoks
2011-09-29 4:33 ` David Miller
2011-09-29 7:46 ` Oliver Hartkopp [this message]
2011-09-29 7:58 ` David Miller
2011-09-29 8:04 ` Oliver Hartkopp
2011-09-29 8:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E842266.9090407@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=nautsch@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).