From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: netdev@vger.kernel.org
Subject: [iproute2 PATCH 09/11] Fix file descriptor leak on error in read_mroute_list()
Date: Mon, 03 Oct 2011 17:24:18 +0200 [thread overview]
Message-ID: <4E89D3A2.1060605@intra2net.com> (raw)
Detected by cppcheck.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
ip/ipmroute.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ip/ipmroute.c b/ip/ipmroute.c
index f033349..945727d 100644
--- a/ip/ipmroute.c
+++ b/ip/ipmroute.c
@@ -85,8 +85,10 @@ static void read_mroute_list(FILE *ofp)
if (!fp)
return;
- if (!fgets(buf, sizeof(buf), fp))
+ if (!fgets(buf, sizeof(buf), fp)) {
+ fclose(fp);
return;
+ }
while (fgets(buf, sizeof(buf), fp)) {
inet_prefix maddr, msrc;
--
1.7.4.4
reply other threads:[~2011-10-03 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89D3A2.1060605@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).