* [PATCH] tg3: Dont dump registers if interface not ready. @ 2011-09-29 2:10 Joe Jin 2011-09-29 6:50 ` Xiao Jiang 0 siblings, 1 reply; 6+ messages in thread From: Joe Jin @ 2011-09-29 2:10 UTC (permalink / raw) To: Matt Carlson, Michael Chan Cc: Guru Anbalagane, Gurudas Pai, Joe Jin, netdev, linux-kernel@vger.kernel.org, Greg Marsden When bootup the server with BCM5704 Gigabit Ethernet get below warning: tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip. <Registers state of device> tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)] tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)] tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 tg3 0000:03:01.0: eth0: Link is down tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX If device not ready, then would not dump registers info. Signed-off-by: Joe Jin <joe.jin@oracle.com> Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com> Reported-by: Gurudas Pai <gurudas.pai@oracle.com> Cc: Matt Carlson <mcarlson@broadcom.com> Cc: Michael Chan <mchan@broadcom.com> --- drivers/net/tg3.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4a1374d..d79d344 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp) { u32 val; bool real_error = false; + bool dump = true; if (tg3_flag(tp, ERROR_PROCESSED)) return; + /* If interface not ready then dont dump error */ + if (!netif_carrier_ok(tp->dev)) + dump = false; + /* Check Flow Attention register */ val = tr32(HOSTCC_FLOW_ATTN); if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) { @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp) } if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) { - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); + if (dump) + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); real_error = true; } if (!real_error) return; - tg3_dump_state(tp); + if (dump) + tg3_dump_state(tp); tg3_flag_set(tp, ERROR_PROCESSED); schedule_work(&tp->reset_task); -- 1.7.6.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tg3: Dont dump registers if interface not ready. 2011-09-29 2:10 [PATCH] tg3: Dont dump registers if interface not ready Joe Jin @ 2011-09-29 6:50 ` Xiao Jiang 2011-10-05 2:14 ` Matt Carlson 0 siblings, 1 reply; 6+ messages in thread From: Xiao Jiang @ 2011-09-29 6:50 UTC (permalink / raw) To: Joe Jin Cc: Matt Carlson, Michael Chan, Guru Anbalagane, Gurudas Pai, netdev, linux-kernel@vger.kernel.org, Greg Marsden Joe Jin wrote: > When bootup the server with BCM5704 Gigabit Ethernet get below warning: > > tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip. > <Registers state of device> > tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)] > tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)] > tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex > tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX > tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 > tg3 0000:03:01.0: eth0: Link is down > tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex > tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX > > If device not ready, then would not dump registers info. > > Signed-off-by: Joe Jin <joe.jin@oracle.com> > Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com> > Reported-by: Gurudas Pai <gurudas.pai@oracle.com> > Cc: Matt Carlson <mcarlson@broadcom.com> > Cc: Michael Chan <mchan@broadcom.com> > --- > drivers/net/tg3.c | 11 +++++++++-- > Maybe this one should based on net-next tree too, the tg3.c is lived below ./drivers/net/ethernet/broadcom/ in that tree. Thanks, Xiao Jiang > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > index 4a1374d..d79d344 100644 > --- a/drivers/net/tg3.c > +++ b/drivers/net/tg3.c > @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp) > { > u32 val; > bool real_error = false; > + bool dump = true; > > if (tg3_flag(tp, ERROR_PROCESSED)) > return; > > + /* If interface not ready then dont dump error */ > + if (!netif_carrier_ok(tp->dev)) > + dump = false; > + > /* Check Flow Attention register */ > val = tr32(HOSTCC_FLOW_ATTN); > if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) { > @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp) > } > > if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) { > - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); > + if (dump) > + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); > real_error = true; > } > > if (!real_error) > return; > > - tg3_dump_state(tp); > + if (dump) > + tg3_dump_state(tp); > > tg3_flag_set(tp, ERROR_PROCESSED); > schedule_work(&tp->reset_task); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tg3: Dont dump registers if interface not ready. 2011-09-29 6:50 ` Xiao Jiang @ 2011-10-05 2:14 ` Matt Carlson 2011-10-08 3:21 ` Joe Jin 2011-10-17 9:52 ` Joe Jin 0 siblings, 2 replies; 6+ messages in thread From: Matt Carlson @ 2011-10-05 2:14 UTC (permalink / raw) To: Xiao Jiang Cc: Joe Jin, Matthew Carlson, Michael Chan, Guru Anbalagane, Gurudas Pai, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Marsden On Wed, Sep 28, 2011 at 11:50:01PM -0700, Xiao Jiang wrote: > Joe Jin wrote: > > When bootup the server with BCM5704 Gigabit Ethernet get below warning: > > > > tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip. > > <Registers state of device> > > tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)] > > tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)] > > tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex > > tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX > > tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 > > tg3 0000:03:01.0: eth0: Link is down > > tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex > > tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX > > > > If device not ready, then would not dump registers info. > > > > Signed-off-by: Joe Jin <joe.jin@oracle.com> > > Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com> > > Reported-by: Gurudas Pai <gurudas.pai@oracle.com> > > Cc: Matt Carlson <mcarlson@broadcom.com> > > Cc: Michael Chan <mchan@broadcom.com> > > --- > > drivers/net/tg3.c | 11 +++++++++-- > > > Maybe this one should based on net-next tree too, the tg3.c > is lived below ./drivers/net/ethernet/broadcom/ in that tree. > > Thanks, > Xiao Jiang > > 1 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > > index 4a1374d..d79d344 100644 > > --- a/drivers/net/tg3.c > > +++ b/drivers/net/tg3.c > > @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp) > > { > > u32 val; > > bool real_error = false; > > + bool dump = true; > > > > if (tg3_flag(tp, ERROR_PROCESSED)) > > return; > > > > + /* If interface not ready then dont dump error */ > > + if (!netif_carrier_ok(tp->dev)) > > + dump = false; Would you still experience the problem if you did the following instead of the above link check? if (tg3_flag(tp, INIT_COMPLETE)) dump = false; > > /* Check Flow Attention register */ > > val = tr32(HOSTCC_FLOW_ATTN); > > if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) { > > @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp) > > } > > > > if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) { > > - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); > > + if (dump) > > + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); > > real_error = true; > > } > > > > if (!real_error) > > return; > > > > - tg3_dump_state(tp); > > + if (dump) > > + tg3_dump_state(tp); > > > > tg3_flag_set(tp, ERROR_PROCESSED); > > schedule_work(&tp->reset_task); > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tg3: Dont dump registers if interface not ready. 2011-10-05 2:14 ` Matt Carlson @ 2011-10-08 3:21 ` Joe Jin 2011-10-17 9:52 ` Joe Jin 1 sibling, 0 replies; 6+ messages in thread From: Joe Jin @ 2011-10-08 3:21 UTC (permalink / raw) To: Matt Carlson Cc: Xiao Jiang, Michael Chan, Guru Anbalagane, Gurudas Pai, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Marsden >>> >>> + /* If interface not ready then dont dump error */ >>> + if (!netif_carrier_ok(tp->dev)) >>> + dump = false; > > Would you still experience the problem if you did the following instead > of the above link check? > > if (tg3_flag(tp, INIT_COMPLETE)) > dump = false; I'll try it then update you. Thanks, Joe ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tg3: Dont dump registers if interface not ready. 2011-10-05 2:14 ` Matt Carlson 2011-10-08 3:21 ` Joe Jin @ 2011-10-17 9:52 ` Joe Jin 2012-03-22 13:17 ` Luis Henriques 1 sibling, 1 reply; 6+ messages in thread From: Joe Jin @ 2011-10-17 9:52 UTC (permalink / raw) To: Matt Carlson Cc: Xiao Jiang, Michael Chan, Guru Anbalagane, Gurudas Pai, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Marsden Hi Matt, Sorry for late response, after apply your changes, driver did not dumped registers info as well, but still hit tg3_stop_block timed out as below: tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 tg3 0000:03:01.0: eth0: Link is down tg3 0000:03:01.1: eth1: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.1: eth1: Flow control is off for TX and off for RX tg3 0000:03:01.1: eth1: Link is down tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 tg3 0000:03:01.0: eth0: Link is down RPC: Registered named UNIX socket transport module. RPC: Registered udp transport module. RPC: Registered tcp transport module. RPC: Registered tcp NFSv4.1 backchannel transport module. SELinux: initialized (dev rpc_pipefs, type rpc_pipefs), uses genfs_contexts tg3 0000:03:01.1: eth1: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.1: eth1: Flow control is off for TX and off for RX tg3 0000:03:01.1: eth1: Link is down tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 tg3 0000:03:01.0: eth0: Link is down tg3 0000:03:01.1: eth1: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.1: eth1: Flow control is off for TX and off for RX ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready Any suggestion? Thanks, Joe On 10/05/11 10:14, Matt Carlson wrote: > On Wed, Sep 28, 2011 at 11:50:01PM -0700, Xiao Jiang wrote: >> Joe Jin wrote: >>> When bootup the server with BCM5704 Gigabit Ethernet get below warning: >>> >>> tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip. >>> <Registers state of device> >>> tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)] >>> tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)] >>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex >>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX >>> tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 >>> tg3 0000:03:01.0: eth0: Link is down >>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex >>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX >>> >>> If device not ready, then would not dump registers info. >>> >>> Signed-off-by: Joe Jin <joe.jin@oracle.com> >>> Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com> >>> Reported-by: Gurudas Pai <gurudas.pai@oracle.com> >>> Cc: Matt Carlson <mcarlson@broadcom.com> >>> Cc: Michael Chan <mchan@broadcom.com> >>> --- >>> drivers/net/tg3.c | 11 +++++++++-- >>> >> Maybe this one should based on net-next tree too, the tg3.c >> is lived below ./drivers/net/ethernet/broadcom/ in that tree. >> >> Thanks, >> Xiao Jiang >>> 1 files changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c >>> index 4a1374d..d79d344 100644 >>> --- a/drivers/net/tg3.c >>> +++ b/drivers/net/tg3.c >>> @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp) >>> { >>> u32 val; >>> bool real_error = false; >>> + bool dump = true; >>> >>> if (tg3_flag(tp, ERROR_PROCESSED)) >>> return; >>> >>> + /* If interface not ready then dont dump error */ >>> + if (!netif_carrier_ok(tp->dev)) >>> + dump = false; > > Would you still experience the problem if you did the following instead > of the above link check? > > if (tg3_flag(tp, INIT_COMPLETE)) > dump = false; > >>> /* Check Flow Attention register */ >>> val = tr32(HOSTCC_FLOW_ATTN); >>> if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) { >>> @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp) >>> } >>> >>> if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) { >>> - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); >>> + if (dump) >>> + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); >>> real_error = true; >>> } >>> >>> if (!real_error) >>> return; >>> >>> - tg3_dump_state(tp); >>> + if (dump) >>> + tg3_dump_state(tp); >>> >>> tg3_flag_set(tp, ERROR_PROCESSED); >>> schedule_work(&tp->reset_task); >>> >> >> > -- Oracle <http://www.oracle.com> Joe Jin | Software Development Senior Manager | +8610.6106.5624 ORACLE | Linux and Virtualization No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tg3: Dont dump registers if interface not ready. 2011-10-17 9:52 ` Joe Jin @ 2012-03-22 13:17 ` Luis Henriques 0 siblings, 0 replies; 6+ messages in thread From: Luis Henriques @ 2012-03-22 13:17 UTC (permalink / raw) To: Joe Jin Cc: Matt Carlson, Xiao Jiang, Michael Chan, Guru Anbalagane, Gurudas Pai, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Marsden, Luis Henriques Joe Jin <joe.jin@oracle.com> writes: Hi, > Hi Matt, > > Sorry for late response, after apply your changes, driver did not dumped > registers info as well, but still hit tg3_stop_block timed out as below: > ... > > Any suggestion? I was wondering if there any progress with this patch. Is this stalled, or has it been dropped? Cheers, -- Luis > > Thanks, > Joe > > On 10/05/11 10:14, Matt Carlson wrote: >> On Wed, Sep 28, 2011 at 11:50:01PM -0700, Xiao Jiang wrote: >>> Joe Jin wrote: >>>> When bootup the server with BCM5704 Gigabit Ethernet get below warning: >>>> >>>> tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip. >>>> <Registers state of device> >>>> tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)] >>>> tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)] >>>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex >>>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX >>>> tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2 >>>> tg3 0000:03:01.0: eth0: Link is down >>>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex >>>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX >>>> >>>> If device not ready, then would not dump registers info. >>>> >>>> Signed-off-by: Joe Jin <joe.jin@oracle.com> >>>> Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle.com> >>>> Reported-by: Gurudas Pai <gurudas.pai@oracle.com> >>>> Cc: Matt Carlson <mcarlson@broadcom.com> >>>> Cc: Michael Chan <mchan@broadcom.com> >>>> --- >>>> drivers/net/tg3.c | 11 +++++++++-- >>>> >>> Maybe this one should based on net-next tree too, the tg3.c >>> is lived below ./drivers/net/ethernet/broadcom/ in that tree. >>> >>> Thanks, >>> Xiao Jiang >>>> 1 files changed, 9 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c >>>> index 4a1374d..d79d344 100644 >>>> --- a/drivers/net/tg3.c >>>> +++ b/drivers/net/tg3.c >>>> @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp) >>>> { >>>> u32 val; >>>> bool real_error = false; >>>> + bool dump = true; >>>> >>>> if (tg3_flag(tp, ERROR_PROCESSED)) >>>> return; >>>> >>>> + /* If interface not ready then dont dump error */ >>>> + if (!netif_carrier_ok(tp->dev)) >>>> + dump = false; >> >> Would you still experience the problem if you did the following instead >> of the above link check? >> >> if (tg3_flag(tp, INIT_COMPLETE)) >> dump = false; >> >>>> /* Check Flow Attention register */ >>>> val = tr32(HOSTCC_FLOW_ATTN); >>>> if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) { >>>> @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp) >>>> } >>>> >>>> if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) { >>>> - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); >>>> + if (dump) >>>> + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n"); >>>> real_error = true; >>>> } >>>> >>>> if (!real_error) >>>> return; >>>> >>>> - tg3_dump_state(tp); >>>> + if (dump) >>>> + tg3_dump_state(tp); >>>> >>>> tg3_flag_set(tp, ERROR_PROCESSED); >>>> schedule_work(&tp->reset_task); >>>> >>> >>> >> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-22 13:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-09-29 2:10 [PATCH] tg3: Dont dump registers if interface not ready Joe Jin 2011-09-29 6:50 ` Xiao Jiang 2011-10-05 2:14 ` Matt Carlson 2011-10-08 3:21 ` Joe Jin 2011-10-17 9:52 ` Joe Jin 2012-03-22 13:17 ` Luis Henriques
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).