From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, rayagond@vayavyalabs.com
Subject: Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support
Date: Wed, 12 Oct 2011 08:37:31 +0200 [thread overview]
Message-ID: <4E9535AB.6020608@st.com> (raw)
In-Reply-To: <20111011.154203.569015025155780686.davem@davemloft.net>
On 10/11/2011 9:42 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Tue, 11 Oct 2011 09:30:42 +0200
>
>> From: Rayagond Kokatanur <rayagond@vayavyalabs.com>
>>
>> This patch enhances the STMMAC driver to support CHAINED mode of
>> descriptor (useful also on validation side).
>>
>> STMMAC supports DMA descriptor to operate both in dual buffer(RING)
>> and linked-list(CHAINED) mode. In RING mode (default) each descriptor
>> points to two data buffer pointers whereas in CHAINED mode they point
>> to only one data buffer pointer.
>>
>> In CHAINED mode each descriptor will have pointer to next descriptor in
>> the list, hence creating the explicit chaining in the descriptor itself,
>> whereas such explicit chaining is not possible in RING mode.
>>
>> Signed-off-by: Rayagond Kokatanur <rayagond@vayavyalabs.com>
>> Hacked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
> These ifdefs added all over the place in the foo.c files are terrible.
>
> Abstract out the differences between RING and CHAINED mode into helper
> inline routines which live in some foo.h header file, that way you won't
> need any ifdefs in the driver foo.c files.
Hello David
I'll rework the patch and send all these updates to the mailing list
again (as V2).
Peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-10-12 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 7:30 [net-next 0/5] stmmac: update to Oct 2011 version Giuseppe CAVALLARO
2011-10-11 7:30 ` [net-next 1/5] stmmac: add CHAINED descriptor mode support Giuseppe CAVALLARO
2011-10-11 19:42 ` David Miller
2011-10-12 6:37 ` Giuseppe CAVALLARO [this message]
2011-10-11 7:30 ` [net-next 2/5] stmmac: allow mtu bigger than 1500 in case of normal desc Giuseppe CAVALLARO
2011-10-11 7:30 ` [net-next 3/5] stmmac: protect tx process with lock Giuseppe CAVALLARO
2011-10-11 7:30 ` [net-next 4/5] stmmac: Stop advertising 1000Base capabilties for non GMII iface (v2) Giuseppe CAVALLARO
2011-10-11 7:30 ` [net-next 5/5] stmmac: update the driver version and doc Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9535AB.6020608@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rayagond@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).