From: Jim Sansing <jjsansing@verizon.net>
To: Linux Network Development list <netdev@vger.kernel.org>
Subject: Comment on nf_queue NF_STOLEN patch
Date: Tue, 18 Oct 2011 15:08:29 -0400 [thread overview]
Message-ID: <4E9DCEAD.7070603@verizon.net> (raw)
In-Reply-To: <CAEuXFEy89F_=J_PJMSbQ1fDcOEkkpz2vucq3LcToi7rTcZHcDA@mail.gmail.com>
I have been working on a kernel module that registers with netfilter,
and I noticed that a patch was added to nf_queue that changed the
handling of return code NF_FILTER from 'do nothing' to 'free the skb'.
I'm not sure which kernel version this went in, but the date of the
patch is Feb, 19, 2010.
Everything I have read about netfilter states that it is up to the
netfilter hook to free the skb if NF_STOLEN is returned. The
implications of this patch from a hook programming perspective are:
1) If the skb is used after the return from the hook, it must be cloned.
2) The original skb must not be freed.
I suggest that a comment be added to include/linux/netfilter.h that says
explicitly the skb will be freed if NF_STOLEN is returned.
Later . . . Jim
next prev parent reply other threads:[~2011-10-18 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 19:18 Problem with ixgbe and TX locked on one cpu Paweł Staszewski
2011-10-18 18:57 ` Jesse Brandeburg
2011-10-18 19:08 ` Jim Sansing [this message]
2011-10-18 21:23 ` Comment on nf_queue NF_STOLEN patch Eric Dumazet
2011-10-18 21:34 ` Jim Sansing
2011-10-19 4:10 ` Eric Dumazet
2011-10-20 10:30 ` Pablo Neira Ayuso
2011-10-19 9:21 ` Problem with ixgbe and TX locked on one cpu Paweł Staszewski
2011-10-19 9:21 ` Paweł Staszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9DCEAD.7070603@verizon.net \
--to=jjsansing@verizon.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).