From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [RFC PATCH 0/5] SUNRPC: "RPC pipefs per network namespace" preparations Date: Thu, 20 Oct 2011 16:56:02 +0400 Message-ID: <4EA01A62.6020209@parallels.com> References: <20111017120629.4541.67395.stgit@localhost6.localdomain6> <4EA000C6.1040502@parallels.com> <20111020123242.GN5444@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "devel@openvz.org" To: "bfields@fieldses.org" Return-path: In-Reply-To: <20111020123242.GN5444@fieldses.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org 20.10.2011 16:32, bfields@fieldses.org =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Thu, Oct 20, 2011 at 03:06:46PM +0400, Stanislav Kinsbursky wrote: >> Guys, please, spend some of your expensive time to review this patch= -set briefly. > > I'll try to take a look soon, but I'm travelling tomorrow through the > 31st, and things will be a little hectic. > Thanks for your time, Bruce. > Just one quick comment: > >>> The only problem about I'm not sure how to solve properly yet, is a= uth gss >>> pipes creations operations. Hoping for some help with it. > > I suspect one reason it may be a little complicated is the > upcall-version switching. The old version is deprecated, and there's= no > need to support the combination of the old version with the a new > feature like containers. And now that it's been there a while the > version-switching code already achieved its goal of avoiding a flag d= ay. > So, one approach might be: > > - move all the code for the old gss upcall and for the version > switching under a new CONFIG_DEPRECATED_GSS, or similar. > - print a warning if the old stuff is used, and plan to rip it > out completely in a future kernel version. > - do something that works just in the !CONFIG_DEPRECATED_GSS > case. > Thanks for this comment. I'll check the code for problem you mentioned = here. But I was actually talking about other thing. Currently we create pipe in gss without any checks since we assume, tha= t pipefs=20 client dir is created already. But with approach, represented in this patch set, pipes and dirs will b= e created=20 only when pipefs was mounted from user-space. I.e. clients with gss aut= h may=20 already present and some callback is required for creating gss pipes. And also this approch assumes existence of gss auth without pipe. > Would that help? > > --b. --=20 Best regards, Stanislav Kinsbursky