From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction Date: Fri, 28 Oct 2011 13:49:12 +0400 Message-ID: <4EAA7A98.5070502@parallels.com> References: <20111025100826.12689.46944.stgit@localhost6.localdomain6> <20111025101716.12689.81697.stgit@localhost6.localdomain6> <20111027213038.GD31669@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "devel@openvz.org" To: "J. Bruce Fields" Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:44444 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755008Ab1J1Jsa (ORCPT ); Fri, 28 Oct 2011 05:48:30 -0400 In-Reply-To: <20111027213038.GD31669@fieldses.org> Sender: netdev-owner@vger.kernel.org List-ID: 28.10.2011 01:30, J. Bruce Fields =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Tue, Oct 25, 2011 at 02:17:18PM +0300, Stanislav Kinsbursky wrote: >> svc_unregister() call have to be removed from svc_destroy() since it= will be >> called in sv_shutdown callback. > > It would be clearer that you're *moving* this if this were merged wit= h > the following patch. And without doing that the series isn't quite > bisectable, unless I'm missing something. > Yes, you are right. Will resend new version soon. > --b. > >> >> Signed-off-by: Stanislav Kinsbursky >> >> --- >> net/sunrpc/svc.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c >> index 918edc3..407462f 100644 >> --- a/net/sunrpc/svc.c >> +++ b/net/sunrpc/svc.c >> @@ -530,7 +530,6 @@ svc_destroy(struct svc_serv *serv) >> if (svc_serv_is_pooled(serv)) >> svc_pool_map_put(); >> >> - svc_unregister(serv); >> kfree(serv->sv_pools); >> kfree(serv); >> } >> --=20 Best regards, Stanislav Kinsbursky