From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH v2] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() Date: Wed, 02 Nov 2011 23:37:29 +0400 Message-ID: <4EB19BF9.8060801@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org, Herbert Xu , devel@openvz.org To: "David S. Miller" Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:46596 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737Ab1KBThp (ORCPT ); Wed, 2 Nov 2011 15:37:45 -0400 Sender: netdev-owner@vger.kernel.org List-ID: v2: extra bracket was removed if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin --- net/bridge/br_input.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index f06ee39..6be8d00 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c @@ -93,10 +93,11 @@ int br_handle_frame_finish(struct sk_buff *skb) skb2 = skb; br->dev->stats.multicast++; - } else if ((dst = __br_fdb_get(br, dest)) && dst->is_local) { + } else if ((dst = __br_fdb_get(br, dest)) != NULL) { skb2 = skb; /* Do not forward the packet since it's local. */ - skb = NULL; + if (dst->is_local) + skb = NULL; } if (skb) { -- 1.7.5.4