From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: kurt.van.dijck@eia.be, netdev@vger.kernel.org,
linux-can@vger.kernel.org, Reuben.Dowle@navico.com
Subject: Re: [PATCH 2/2] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK
Date: Thu, 03 Nov 2011 11:03:46 +0100 [thread overview]
Message-ID: <4EB26702.60506@hartkopp.net> (raw)
In-Reply-To: <1320313675-30749-3-git-send-email-mkl@pengutronix.de>
On 03.11.2011 10:47, Marc Kleine-Budde wrote:
> @@ -609,9 +605,10 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id)
>
> /* transmission complete interrupt */
> if (reg_iflag1 & (1 << FLEXCAN_TX_BUF_ID)) {
> - /* tx_bytes is incremented in flexcan_start_xmit */
> + stats->tx_bytes += can_get_echo_skb(dev, 0);
> stats->tx_packets++;
> flexcan_write((1 << FLEXCAN_TX_BUF_ID), ®s->iflag1);
> + can_get_echo_skb(dev, 0);
> netif_wake_queue(dev);
> }
What's the reason for the second can_get_echo_skb() here?
IIRC the skb is already netif_rx'ed and consumed by the first attempt.
Regards,
Oliver
next prev parent reply other threads:[~2011-11-03 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 22:18 [PATCH] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Reuben Dowle
2011-10-31 22:31 ` Marc Kleine-Budde
2011-10-31 22:43 ` Reuben Dowle
2011-10-31 22:49 ` Marc Kleine-Budde
2011-11-02 0:25 ` Reuben Dowle
2011-11-02 8:04 ` Kurt Van Dijck
2011-11-02 19:46 ` Reuben Dowle
2011-11-02 20:30 ` Oliver Hartkopp
2011-11-02 21:31 ` Reuben Dowle
2011-11-03 9:47 ` [PATCH 0/2] clean up tx_bytes accounting Marc Kleine-Budde
2011-11-03 9:47 ` [PATCH 1/2] can: dev: let can_get_echo_skb() return dlc of CAN frame Marc Kleine-Budde
2011-11-03 9:47 ` [PATCH 2/2] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Marc Kleine-Budde
2011-11-03 9:59 ` Marc Kleine-Budde
2011-11-03 10:03 ` Oliver Hartkopp [this message]
2011-11-03 10:17 ` Marc Kleine-Budde
2011-11-03 10:03 ` [PATCH 0/2] clean up tx_bytes accounting Kurt Van Dijck
2011-11-03 10:42 ` Marc Kleine-Budde
2011-11-03 14:27 ` Oliver Hartkopp
2011-11-03 14:37 ` Kurt Van Dijck
2011-11-03 15:03 ` Marc Kleine-Budde
2011-11-03 14:54 ` [PATCH] flexcan: Fix CAN_RAW_RECV_OWN_MSGS and CAN_RAW_LOOPBACK Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB26702.60506@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=Reuben.Dowle@navico.com \
--cc=kurt.van.dijck@eia.be \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).