From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: Re: [PATCH] rtl8192e: Don't copy huge struct by value (and make it const). Date: Mon, 07 Nov 2011 10:55:46 -0600 Message-ID: <4EB80D92.8050507@lwfinger.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Andrea Merello , Mike McCormack , Greg Kroah-Hartman , netdev@vger.kernel.org To: Jesper Juhl Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/06/2011 05:21 PM, Jesper Juhl wrote: > rtllib_is_shortslot() takes one argument - a struct that's more than a > kilobyte large. It should take a pointer instead of copying such a > huge struct - and the argument might as well be declared 'const' now > that we are at it, since it is not modified. This patch makes these > changes. > > Signed-off-by: Jesper Juhl Acked-by: Larry Finger