From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Jones Subject: Re: [RFC PATCH net-next] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs Date: Mon, 14 Nov 2011 16:06:14 -0800 Message-ID: <4EC1ACF6.9060908@hp.com> References: <20111114215241.5B8BF2900307@tardy> <1321309800.2827.22.camel@bwh-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Rick Jones , netdev@vger.kernel.org, Rusty Russell , Michael Tsirkin , virtualization@lists.linux-foundation.org To: Ben Hutchings Return-path: Received: from g1t0028.austin.hp.com ([15.216.28.35]:3639 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083Ab1KOAGQ (ORCPT ); Mon, 14 Nov 2011 19:06:16 -0500 In-Reply-To: <1321309800.2827.22.camel@bwh-desktop> Sender: netdev-owner@vger.kernel.org List-ID: On 11/14/2011 02:30 PM, Ben Hutchings wrote: > On Mon, 2011-11-14 at 13:52 -0800, Rick Jones wrote: >> From: Rick Jones >> >> Add a new .bus_name to virtio_config_ops then modify virtio_net to >> call through to it in an ethtool .get_drvinfo routine to report >> bus_info in ethtool -i output which is consistent with other >> emulated NICs and the output of lspci. > [...] >> diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/lguest_device.c >> index 0dc30ff..3724d45 100644 >> --- a/drivers/lguest/lguest_device.c >> +++ b/drivers/lguest/lguest_device.c >> @@ -381,6 +381,11 @@ error: >> return PTR_ERR(vqs[i]); >> } >> >> +static const char *lg_bus_name(struct virtio_device *vdev) >> +{ >> + return "Not Implemented"; >> +} > [...] >> +static const char *kvm_bus_name(struct virtio_device *vdev) >> +{ >> + return "Not Implemented"; >> +} > [...] > > Please use the existing 'not implemented' value, which is the empty > string. If you think ethtool should print some helpful message instead > of an empty string, please submit a patch for ethtool. One question - will those actually be called via an ethtool path? In my poking about through the virtio code, I got the impression those modules were for "other than networking" sorts of things. rick