From: Li Wei <lw@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: fix for ip_options_rcv_srr() daddr update.
Date: Tue, 15 Nov 2011 13:40:45 +0800 [thread overview]
Message-ID: <4EC1FB5D.80705@cn.fujitsu.com> (raw)
In-Reply-To: <20111109.155936.1972852290616131285.davem@davemloft.net>
> From: Li Wei <lw@cn.fujitsu.com>
> Date: Wed, 09 Nov 2011 15:39:28 +0800
>
>> When opt->srr_is_hit is set skb_rtable(skb) has been updated for
>> 'nexthop' and iph->daddr should always equals to skb_rtable->rt_dst
>> holds, We need update iph->daddr either.
>>
>> Signed-off-by: Li Wei <lw@cn.fujitsu.com>
>
> Applied, thank you.
>
>
Hi, David
These days i am doing some ICMP tests and sadly found that wen can't update
iph->daddr in ip_options_rcv_srr(), It's too early. When some exception
ocurred later (eg. in ip_forward() when goto sr_failed) we need the ip header
be identical to the original one as ICMP need it.
It seems we need rt->rt_dst in ip_forward_options() and ip_forward() instead
of iph->daddr.
next prev parent reply other threads:[~2011-11-15 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 7:39 [PATCH] ipv4: fix for ip_options_rcv_srr() daddr update Li Wei
2011-11-09 20:59 ` David Miller
2011-11-15 5:40 ` Li Wei [this message]
2011-11-15 6:35 ` David Miller
2011-11-15 7:26 ` Li Wei
2011-11-15 7:28 ` David Miller
2011-11-15 7:51 ` Li Wei
2011-11-15 8:23 ` David Miller
2011-11-15 8:29 ` Li Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC1FB5D.80705@cn.fujitsu.com \
--to=lw@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).