b43: BCM 4331: MacBook 8,1: No connection after suspend

b43: BCM 4331: MacBook 8,1: No connection after suspend

[Nico -telmich- Schottelius]

Hello,

new notebook, new problems (*):

Running 3.2.0-rc1 on the MacBook Pro 8,1 with the BCM4331
(14e4:4331) the WLAN indeed works:

[   86.231702] b43-phy0: Broadcom 4331 WLAN found (core revision 29)
[   86.269190] ieee80211 phy0: Selected rate control algorithm
'minstrel_ht'
[   86.270486] Broadcom 43xx driver loaded [ Features: PMNLS ]
[   87.677265] b43-phy0: Loading firmware version 666.2 (2011-02-23
01:15:07)

But: After a suspend it seems not to receive any packets anymore:

[ 2334.494845] wlan0: authenticate with 64:87:d7:37:89:89 (try 1)
[ 2334.694035] wlan0: authenticate with 64:87:d7:37:89:89 (try 2)
[ 2334.893909] wlan0: authenticate with 64:87:d7:37:89:89 (try 3)
[ 2335.093824] wlan0: authentication with 64:87:d7:37:89:89 timed out

wpa_supplicant thus retries to connect to the network again and again
without success.

This is reproducable on the MBP 8,1 and is *NOT* fixed if I unload
b43 and modprobe it again. It is also "not fixed" when doing
multiple suspends/resumes.

Any pointers to this?

Cheers,

Nico


(*) feels like in good old times...

-- 
PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Nico Schottelius]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Nico -telmich- Schottelius [Fri, Nov 18, 2011 at 06:32:42PM +0100]:
> Hello,
> 
> new notebook, new problems (*):

+ full dmesg attached.

-- 
PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0

[-- Attachment #2: dmesg.no-connection-after-suspend.gz --]
[-- Type: application/octet-stream, Size: 145793 bytes --]

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[John W. Linville]

Arend has nothing to do with b43, and b43 has it's own
mailing list, b43-dev@lists.infradead.org.  Even if it didn't,
linux-wireless@vger.kernel.org would be a more appropriate list than
this one.

John

On Fri, Nov 18, 2011 at 06:32:42PM +0100, Nico -telmich- Schottelius wrote:
> Hello,
> 
> new notebook, new problems (*):
> 
> Running 3.2.0-rc1 on the MacBook Pro 8,1 with the BCM4331
> (14e4:4331) the WLAN indeed works:
> 
> [   86.231702] b43-phy0: Broadcom 4331 WLAN found (core revision 29)
> [   86.269190] ieee80211 phy0: Selected rate control algorithm
> 'minstrel_ht'
> [   86.270486] Broadcom 43xx driver loaded [ Features: PMNLS ]
> [   87.677265] b43-phy0: Loading firmware version 666.2 (2011-02-23
> 01:15:07)
> 
> But: After a suspend it seems not to receive any packets anymore:
> 
> [ 2334.494845] wlan0: authenticate with 64:87:d7:37:89:89 (try 1)
> [ 2334.694035] wlan0: authenticate with 64:87:d7:37:89:89 (try 2)
> [ 2334.893909] wlan0: authenticate with 64:87:d7:37:89:89 (try 3)
> [ 2335.093824] wlan0: authentication with 64:87:d7:37:89:89 timed out
> 
> wpa_supplicant thus retries to connect to the network again and again
> without success.
> 
> This is reproducable on the MBP 8,1 and is *NOT* fixed if I unload
> b43 and modprobe it again. It is also "not fixed" when doing
> multiple suspends/resumes.
> 
> Any pointers to this?
> 
> Cheers,
> 
> Nico
> 
> 
> (*) feels like in good old times...
> 
> -- 
> PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Arend van Spriel]

On 11/18/2011 06:39 PM, Nico Schottelius wrote:
> Nico -telmich- Schottelius [Fri, Nov 18, 2011 at 06:32:42PM +0100]:
>> Hello,
>>
>> new notebook, new problems (*):
> 
> + full dmesg attached.
> 

It seems you are running b43 + bcma. Adding Rafał and friends.

Gr. AvS

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Arend van Spriel]

On 11/18/2011 09:02 PM, Arend van Spriel wrote:
> On 11/18/2011 06:39 PM, Nico Schottelius wrote:
>> Nico -telmich- Schottelius [Fri, Nov 18, 2011 at 06:32:42PM +0100]:
>>> Hello,
>>>
>>> new notebook, new problems (*):
>>
>> + full dmesg attached.
>>
> 
> It seems you are running b43 + bcma. Adding Rafał and friends.
> 
> Gr. AvS

Hi Rafał,

In brcmsmac we reprogram the PCI BAR windows upon resume. Not sure if
that is done or needed in bcma, but may be worth checking.

Gr. AvS

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Rafał Miłecki]

2011/11/18 Arend van Spriel <arend@broadcom.com>:
> On 11/18/2011 09:02 PM, Arend van Spriel wrote:
>> On 11/18/2011 06:39 PM, Nico Schottelius wrote:
>>> Nico -telmich- Schottelius [Fri, Nov 18, 2011 at 06:32:42PM +0100]:
>>>> Hello,
>>>>
>>>> new notebook, new problems (*):
>>>
>>> + full dmesg attached.
>>>
>>
>> It seems you are running b43 + bcma. Adding Rafał and friends.
>>
>> Gr. AvS
>
> Hi Rafał,
>
> In brcmsmac we reprogram the PCI BAR windows upon resume. Not sure if
> that is done or needed in bcma, but may be worth checking.

Good point.

Please reload b43 *and bcma*. Both drivers. Share your results.

-- 
Rafał

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Nico Schottelius]

Rafał Miłecki [Sat, Nov 19, 2011 at 12:08:51AM +0100]:
> > In brcmsmac we reprogram the PCI BAR windows upon resume. Not sure if
> > that is done or needed in bcma, but may be worth checking.
> 
> Good point.
> 
> Please reload b43 *and bcma*. Both drivers. Share your results.

Well, 100 points for you!

rmmod of b43 and bcma and modprobe of b43 afterwards restores
the ability to connect!

Btw, I've found another issue: The signal level seems to be set
to 0 for all networks, thus wpa_supplicant does not select the
best network (Follow the white rabbit! in my case). Thus
I've used "select_network 9" to force connection to the right
networt.

Log attached below.

So, what are the next steps to debug/fix this issue to make me
(and probably everybody else with a macbook pro 8,1) happy after
suspend?

Cheers,

Nico

> scan_results 
bssid / frequency / signal level / flags / ssid
02:0c:42:14:17:01 2412  0 [WPA-EAP-TKIP+CCMP][WPA2-EAP-TKIP+CCMP][ESS]  MONZOON-EAP
00:24:c9:85:e1:60 2412  0 [WPA-PSK-TKIP+CCMP][WPA2-PSK-TKIP+CCMP][WPS][ESS] mtp-35864
60:33:4b:e4:a5:c1 2417  0 [WPA2-PSK-CCMP][ESS]  airport
94:44:52:76:7b:76 2412  0 [WPA-PSK-CCMP][WPA2-PSK-CCMP][WPS][ESS] Belkin.3B76
00:24:93:27:1f:b0 2422  0 [WPA-PSK-TKIP][WPA2-PSK-CCMP][ESS]  vwp-20691
80:c6:ab:2a:05:19 2437  0 [WPA-PSK-TKIP+CCMP][WPA2-PSK-TKIP+CCMP][ESS]  UPC0045190
00:21:1e:65:b0:d0 2447  0 [WPA-PSK-TKIP][WPA2-PSK-CCMP][ESS]  CDQ-69729
00:18:e7:e8:7b:49 2472  0 [WPA-PSK-TKIP+CCMP][WPA2-PSK-TKIP+CCMP][WPS][ESS] MHLAN
00:0c:42:14:17:01 2412  0 [ESS] MONZOON
00:18:39:50:07:f3 2462  0 [ESS] Follow the white rabbit!
00:22:3f:2e:53:94 2462  0 [WPA-PSK-TKIP+CCMP][WPA2-PSK-TKIP+CCMP-preauth][ESS]  strudele
> 
Linux brief 3.2.0-rc1 #83 SMP PREEMPT Tue Nov 8 15:54:52 CET 2011 x86_64 Intel(R) Core(TM) i5-2415M CPU @ 2.30GHz GenuineIntel GNU/Linux

connected, now suspending:

<2>CTRL-EVENT-DISCONNECTED bssid=00:00:00:00:00:00 reason=0
> <2>CTRL-EVENT-SCAN-RESULTS 
> <2>WPS-AP-AVAILABLE 
> <2>Trying to associate with 00:18:39:50:07:f3 (SSID='Follow the white rabbit!' freq=2462 MHz)
> <2>Associated with 00:18:39:50:07:f3
> <2>CTRL-EVENT-CONNECTED - Connection to 00:18:39:50:07:f3 completed (reauth) [id=9 id_str=yvonne]
<2>CTRL-EVENT-DISCONNECTED bssid=00:18:39:50:07:f3 reason=0
> <2>CTRL-EVENT-SCAN-RESULTS 
> <2>WPS-AP-AVAILABLE 
> <2>Trying to associate with 00:18:39:50:07:f3 (SSID='Follow the white rabbit!' freq=2462 MHz)
<2>Authentication with 00:18:39:50:07:f3 timed out.
> 
> terminate 
OK
[20:18] brief:~# rmmod b43
[20:19] brief:~# rmmod bcma
[20:19] brief:~# modprobe b43
WARNING: All config files need .conf: /etc/modprobe.d/modprobe.conf.pacnew, it will be ignored in a future release.
[20:19] brief:~# lsmod| head -3 
Module                  Size  Used by
b43                   355422  0 
bcma                   22546  1 b43
[20:19] brief:~# 
> status 
wpa_state=ASSOCIATING
<2>Authentication with 00:0c:42:14:17:01 timed out.
> <2>CTRL-EVENT-BSS-ADDED 11 94:44:52:51:2e:8a
> <2>CTRL-EVENT-SCAN-RESULTS 
> <2>WPS-AP-AVAILABLE 
> <2>Trying to associate with 00:18:39:50:07:f3 (SSID='Follow the white rabbit!' freq=2462 MHz)
> <2>Associated with 00:18:39:50:07:f3
> <2>CTRL-EVENT-CONNECTED - Connection to 00:18:39:50:07:f3 completed (auth) [id=9 id_str=yvonne]

-- 
PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0

Re: b43: BCM 4331: MacBook 8,1: No connection after suspend

[Rafał Miłecki]

2011/11/19 Nico Schottelius <nico-linux-20111118@schottelius.org>:
> Rafał Miłecki [Sat, Nov 19, 2011 at 12:08:51AM +0100]:
>> > In brcmsmac we reprogram the PCI BAR windows upon resume. Not sure if
>> > that is done or needed in bcma, but may be worth checking.
>>
>> Good point.
>>
>> Please reload b43 *and bcma*. Both drivers. Share your results.
>
> Well, 100 points for you!
>
> rmmod of b43 and bcma and modprobe of b43 afterwards restores
> the ability to connect!

Great! :)


> Btw, I've found another issue: The signal level seems to be set
> to 0 for all networks, thus wpa_supplicant does not select the
> best network (Follow the white rabbit! in my case). Thus
> I've used "select_network 9" to force connection to the right
> networt.

Sorry, you're probably missing two important patches:
b43: fill ctl1 word on all newer PHYs, fix PHY errors
b43: HT-PHY: report signal to mac80211
I believe both will appear in 3.2-rc3.

-- 
Rafał