Patch is wrong

Patch is wrong

[Michael Wang]

Hi, David

I want to argue about this patch:

http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=commit;h=09357b00255c233705b1cf6d76a8d147340545b8

I am the author of this patch, and Jeff only change 0, 1 to false and
true, now he become the author.

This is the original patch:

http://sourceforge.net/mailarchive/forum.php?thread_name=20111118152002.19d3cabc%40asterix.rh&forum_name=e1000-devel

This is my first patch and the result really hurt me, please check and
maintain the justice.

Thanks,
Michael Wang

Re: Patch is wrong

[David Miller]

From: Michael Wang <wangyun@linux.vnet.ibm.com>
Date: Tue, 06 Dec 2011 11:27:08 +0800

> I am the author of this patch, and Jeff only change 0, 1 to false and
> true, now he become the author.

Take it up with Jeff, I pulled the change from his GIT tree and that's
where the authorship information came from.

Unfortunately, it cannot be fixed as it's already pushed out to my
tree.

Re: Patch is wrong

[Michael Wang]

On 12/06/2011 12:39 PM, David Miller wrote:

> From: Michael Wang <wangyun@linux.vnet.ibm.com>
> Date: Tue, 06 Dec 2011 11:27:08 +0800
> 
>> I am the author of this patch, and Jeff only change 0, 1 to false and
>> true, now he become the author.
> 
> Take it up with Jeff, I pulled the change from his GIT tree and that's
> where the authorship information came from.
> 

Hi, David

Jeff know what happened, he promised to add my and Flavio's
signed-off-by in the pre-mail.

It's easy to see from the mail that who is the author, and I have reply
just after Jeff's patch send out to you, I add my signed-off-by and
From, but no one care.

I know you are all experts and have lots of patches in community, you
won't care such a small patch's author, but this is very important for
me because this is my first patch, it's stand for my passion and will to
join the community.

I know it will cost you many works, but I still have to ask you to
replace this patch, because this will become a mistake in Linux, which
will make me sad each time I saw it on git log.

Thanks & Best regards
Michael Wang

> Unfortunately, it cannot be fixed as it's already pushed out to my
> tree.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: Patch is wrong

[David Miller]

From: Michael Wang <wangyun@linux.vnet.ibm.com>
Date: Tue, 06 Dec 2011 13:11:47 +0800

> I know it will cost you many works, but I still have to ask you to
> replace this patch, because this will become a mistake in Linux, which
> will make me sad each time I saw it on git log.

It is simply not possible without screwing over every single person
who follows my tree.

If I go in and pull out the change, then everyone who follows my
tree will have a corrupt tree.

Sorry, mistakes happen, and once they are pushed out to GIT trees
used by lots of people we have to live with it.

Re: Patch is wrong

[Michael Wang]

On 12/06/2011 04:11 PM, Amos Kong wrote:

> On Tue, Dec 6, 2011 at 1:25 PM, David Miller <davem@davemloft.net
> <mailto:davem@davemloft.net>> wrote:
> 
>     From: Michael Wang <wangyun@linux.vnet.ibm.com
>     <mailto:wangyun@linux.vnet.ibm.com>>
>     Date: Tue, 06 Dec 2011 13:11:47 +0800
> 
>     > I know it will cost you many works, but I still have to ask you to
>     > replace this patch, because this will become a mistake in Linux, which
>     > will make me sad each time I saw it on git log.
> 
>     It is simply not possible without screwing over every single person
>     who follows my tree.
> 
>     If I go in and pull out the change, then everyone who follows my
>     tree will have a corrupt tree.
> 
>     Sorry, mistakes happen, and once they are pushed out to GIT trees
>     used by lots of people we have to live with it.
> 
> 
> Send a patch to revert it and re-send a new one with right Author??
> Do you think it's meaningless ;-)
> 

Hi, Amos

Thanks for your suggestion, but I don't want to focus on it any more,
that will cause other's trouble.

So I will try to forgot it as soon as possible :)

Regards,
Michael Wang

>  
> 
>     --
>     To unsubscribe from this list: send the line "unsubscribe netdev" in
>     the body of a message to majordomo@vger.kernel.org
>     <mailto:majordomo@vger.kernel.org>
>     More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: Patch is wrong

[Flavio Leitner]

On Tue, 06 Dec 2011 13:11:47 +0800
Michael Wang <wangyun@linux.vnet.ibm.com> wrote:

> On 12/06/2011 12:39 PM, David Miller wrote:
> 
> > From: Michael Wang <wangyun@linux.vnet.ibm.com>
> > Date: Tue, 06 Dec 2011 11:27:08 +0800
> > 
> >> I am the author of this patch, and Jeff only change 0, 1 to false
> >> and true, now he become the author.
> > 
> > Take it up with Jeff, I pulled the change from his GIT tree and
> > that's where the authorship information came from.
> > 
> 
> Hi, David
> 
> Jeff know what happened, he promised to add my and Flavio's
> signed-off-by in the pre-mail.
> 
> It's easy to see from the mail that who is the author, and I have
> reply just after Jeff's patch send out to you, I add my signed-off-by
> and From, but no one care.
> 
> I know you are all experts and have lots of patches in community, you
> won't care such a small patch's author, but this is very important for
> me because this is my first patch, it's stand for my passion and will
> to join the community.
> 

Hi Michael,

I think you should be proud of yourself because we worked from
the problem definition, then confirmation of the root cause to
the patch fixing it, which was accepted with a couple of simple
changes. However, it's still basically what we had posted.

I understand your frustration about the author thing (I've been
there). Perhaps this could be an example to sub-tree maintainers
to act more as a coach and always require the submitter to fix
the patch instead of changing it themselves, that is, like Davem
does for net and net-next trees.

Anyway, there are plenty of bugs out there to be fixed and we
will appreciate your help fixing them :)

cheers!
fbl
(sorry the late replies, I was on vacations without e-mail access)