From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Amos Kong <kongjianjun@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linuxram@us.ibm.com, fbl@redhat.com,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com
Subject: Re: Patch is wrong
Date: Tue, 06 Dec 2011 16:19:48 +0800 [thread overview]
Message-ID: <4EDDD024.5000102@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFeW=pZXgfNAy_f_HkgUjt+Rh7VwTXpkwiog1ki=fnDJ6_by4g@mail.gmail.com>
On 12/06/2011 04:11 PM, Amos Kong wrote:
> On Tue, Dec 6, 2011 at 1:25 PM, David Miller <davem@davemloft.net
> <mailto:davem@davemloft.net>> wrote:
>
> From: Michael Wang <wangyun@linux.vnet.ibm.com
> <mailto:wangyun@linux.vnet.ibm.com>>
> Date: Tue, 06 Dec 2011 13:11:47 +0800
>
> > I know it will cost you many works, but I still have to ask you to
> > replace this patch, because this will become a mistake in Linux, which
> > will make me sad each time I saw it on git log.
>
> It is simply not possible without screwing over every single person
> who follows my tree.
>
> If I go in and pull out the change, then everyone who follows my
> tree will have a corrupt tree.
>
> Sorry, mistakes happen, and once they are pushed out to GIT trees
> used by lots of people we have to live with it.
>
>
> Send a patch to revert it and re-send a new one with right Author??
> Do you think it's meaningless ;-)
>
Hi, Amos
Thanks for your suggestion, but I don't want to focus on it any more,
that will cause other's trouble.
So I will try to forgot it as soon as possible :)
Regards,
Michael Wang
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2011-12-06 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 3:27 Patch is wrong Michael Wang
2011-12-06 4:39 ` David Miller
2011-12-06 5:11 ` Michael Wang
2011-12-06 5:25 ` David Miller
[not found] ` <CAFeW=pZXgfNAy_f_HkgUjt+Rh7VwTXpkwiog1ki=fnDJ6_by4g@mail.gmail.com>
2011-12-06 8:19 ` Michael Wang [this message]
2011-12-06 12:10 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDDD024.5000102@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kongjianjun@gmail.com \
--cc=linuxram@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).