From: Wolfgang Grandegger <wg@grandegger.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>,
Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] pch_can: fix error passive level test
Date: Mon, 12 Dec 2011 09:05:45 +0100 [thread overview]
Message-ID: <4EE5B5D9.3030702@grandegger.com> (raw)
In-Reply-To: <1323674180-16916-1-git-send-email-xi.wang@gmail.com>
On 12/12/2011 08:16 AM, Xi Wang wrote:
> The test (((errc & PCH_REC) >> 8) > 127) would always be false because
> the receive error counter ((errc & PCH_REC) >> 8) is at most 127, where
> PCH_REC is defined as 0x7f00. To test whether the receive error counter
> has reached the error passive level, the RP bit (15) should be used.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
The C_CAN driver, which supports the same CAN controller, does handle
the error passive state correctly. This reminds me to get rid of pch_can
in favor of C_CAN sooner than later.
Thanks,
Wolfgang.
next prev parent reply other threads:[~2011-12-12 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 7:16 [PATCH] pch_can: fix error passive level test Xi Wang
2011-12-12 8:05 ` Wolfgang Grandegger [this message]
2011-12-12 9:17 ` Marc Kleine-Budde
2011-12-12 9:31 ` Wolfgang Grandegger
2011-12-12 9:39 ` Marc Kleine-Budde
2011-12-12 9:50 ` Wolfgang Grandegger
2012-01-07 23:47 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE5B5D9.3030702@grandegger.com \
--to=wg@grandegger.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).