From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Wei Subject: Re: [PATCH] ipv6: Fix for adding multicast route for loopback device automatically. Date: Tue, 13 Dec 2011 08:56:15 +0800 Message-ID: <4EE6A2AF.7040303@cn.fujitsu.com> References: <4EDF1481.1080106@cn.fujitsu.com> <20111207.150615.181825066035193136.davem@davemloft.net> <4EE00BAD.3010409@cn.fujitsu.com> <20111212.184929.1998244574424635802.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org To: David Miller Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:61326 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753890Ab1LMAzz (ORCPT ); Mon, 12 Dec 2011 19:55:55 -0500 In-Reply-To: <20111212.184929.1998244574424635802.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: > From: Li Wei > Date: Thu, 08 Dec 2011 08:58:21 +0800 > >> The problem is that the resulting routing table depends on the sequence >> of interface's initialization and in some situation, that would block all >> muticast packets. Suppose there are two interfaces on my computer >> (lo and eth0), if we initailize 'lo' before 'eth0', the resuting routing >> table(for multicast) would be >> >> # ip -6 route show | grep ff00:: >> unreachable ff00::/8 dev lo metric 256 error -101 >> ff00::/8 dev eth0 metric 256 >> >> When sending multicasting packets, routing subsystem will return the first >> route entry which with a error set to -101(ENETUNREACH). >> >> I know the kernel will set the default ipv6 address for 'lo' when it is up >> and won't set the default multicast route for it, but there is no reason to >> stop 'init' program from setting address for 'lo', and that is exactly what >> systemd did. > > Ok, I added this more detailed explanation to the commit message and > applied your patch. > > Probably it is a good idea to explain things completely, with all details > and examples, in the commit message from the beginning :-) > > Thanks David, remember your advice :)