From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] sctp: Do not account for sizeof(struct sk_buff) in estimated rwnd
Date: Tue, 20 Dec 2011 13:01:13 -0500 [thread overview]
Message-ID: <4EF0CD69.9000602@hp.com> (raw)
In-Reply-To: <20111220093910.GB21801@canuck.infradead.org>
On 12/20/2011 04:39 AM, Thomas Graf wrote:
> On Tue, Dec 20, 2011 at 01:00:48PM +0800, Wei Yongjun wrote:
>> I saw you discussed this with Vlad in old mail:
>> http://www.spinics.net/lists/linux-sctp/msg01365.html
>>
>> You said you will update patch to include a per packet overhead,
>> but it does not include in this patch, what's wrong with in?
>
> It's not possible because upon retransmission of a chunk we need
> to readd the overhead to the rwnd. There is no longer a reference
> to a packet so we can't know how much to add. This explanation is
> also in the original mail thread.
>
Right. The original patches were done to work around the problem of
leftover rwnd when socket buffer is exhausted and they didn't really
address the problem sufficiently. It was still possible to reach that
condition. Some subsequent patches added support to address this issue
a different way. As a result, I think this revert is just fine.
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
-vlad
next prev parent reply other threads:[~2011-12-20 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 5:00 [PATCH] sctp: Do not account for sizeof(struct sk_buff) in estimated rwnd Wei Yongjun
2011-12-20 9:39 ` Thomas Graf
2011-12-20 18:01 ` Vlad Yasevich [this message]
2011-12-20 18:59 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 14:11 Thomas Graf
2011-12-19 20:10 ` David Miller
2011-12-19 23:19 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0CD69.9000602@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).